You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/07/09 01:25:50 UTC
[GitHub] [geode] jdeppe-pivotal opened a new pull request #6682: GEODE-9419: Handle IOExceptions when Radish clients disconnect
jdeppe-pivotal opened a new pull request #6682:
URL: https://github.com/apache/geode/pull/6682
- This restores some of the behavior of GEODE-9411
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #6682: GEODE-9419: Handle IOExceptions when Radish clients disconnect
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #6682:
URL: https://github.com/apache/geode/pull/6682#issuecomment-877250207
Since `IOException`s are checked, the implication is that they may be recoverable. However, in this case since netty is telling us about this problem, there isn't anything we can do about it. We're being told that the client is gone and we can perform any necessary cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #6682: GEODE-9419: Handle IOExceptions when Radish clients disconnect
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #6682:
URL: https://github.com/apache/geode/pull/6682#issuecomment-876854456
Some small refactoring changes aside, this seems to just be a revert of GEODE-9411. Is there some middle ground solution that would prevent the spurious exception logging from Netty but preserve the behaviour where we don't close the connection if we hit any `IOException` at all, regardless of the origin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal closed pull request #6682: GEODE-9419: Handle IOExceptions when Radish clients disconnect
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal closed pull request #6682:
URL: https://github.com/apache/geode/pull/6682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] DonalEvans commented on pull request #6682: GEODE-9419: Handle IOExceptions when Radish clients disconnect
Posted by GitBox <gi...@apache.org>.
DonalEvans commented on pull request #6682:
URL: https://github.com/apache/geode/pull/6682#issuecomment-877306296
> Since `IOException`s are checked, the implication is that they may be recoverable. However, in this case since netty is telling us about this problem, there isn't anything we can do about it. We're being told that the client is gone and we can perform any necessary cleanup.
Aah, I see now. As long as we can be sure that we only see an `IOException` when the client is gone, and not in other cases, then it should be fine to just revert the entire commit for GEODE-9411. If we think there might be cases where an `IOException` is thrown and we don't want to close the connection, maybe we could check for the "Connection reset by peer" message in the exception and close if we see that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode] jdeppe-pivotal commented on pull request #6682: GEODE-9419: Handle IOExceptions when Radish clients disconnect
Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on pull request #6682:
URL: https://github.com/apache/geode/pull/6682#issuecomment-878300351
Closing in favor of a complete revert.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org