You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@teaclave.apache.org by GitBox <gi...@apache.org> on 2020/07/19 15:18:18 UTC
[GitHub] [incubator-teaclave-sgx-sdk] volcano0dr commented on a change in pull request #258: Change sgx_libc Interface for Rust Crates.
volcano0dr commented on a change in pull request #258:
URL: https://github.com/apache/incubator-teaclave-sgx-sdk/pull/258#discussion_r456920956
##########
File path: sgx_tstd/src/sys/fd.rs
##########
@@ -205,13 +171,13 @@ impl FileDesc {
FileDesc::new(fd)
});
}
- Err(ref e) if e.raw_os_error() == Some(libc::EINVAL) => {
+ Err(ref e) if e.equal_to_os_error(libc::EINVAL) => {
TRY_CLOEXEC.store(false, Ordering::Relaxed);
Review comment:
I think Relaxed is okay.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@teaclave.apache.org
For additional commands, e-mail: notifications-help@teaclave.apache.org