(iceberg-python) branch main updated: Build: Decouple setup and exec in integration tests for better flexibility (#1985)

[ke...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

kevinjqliu pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-python.git


The following commit(s) were added to refs/heads/main by this push:
     new a27bec3c Build: Decouple setup and exec in integration tests for better flexibility (#1985)
a27bec3c is described below

commit a27bec3c075f688461cd54d9ef02359f724d90f8
Author: frankliee <fr...@tencent.com>
AuthorDate: Sun May 11 00:26:34 2025 +0800

    Build: Decouple setup and exec in integration tests for better flexibility (#1985)
    
    <!--
    Thanks for opening a pull request!
    -->
    
    <!-- In the case this PR will resolve an issue, please replace
    ${GITHUB_ISSUE_ID} below with the actual Github issue id. -->
    <!-- Closes #${GITHUB_ISSUE_ID} -->
    
    # Rationale for this change
    
    Decouple setup and exec in integration tests for better flexibility and
    isolation.
    
    For example, currently, `make test-integration` must be executed in a
    physical server.
    It is because `docker xxx` cannot be executed within a container (docker
    in docker is out of scope of this PR).
    Sometimes, it is useful for local debugging, as poetry cannot provide
    system level isolation, includes environment variables and shared libs.
    
    This PR allows us to run `make test-integration-exec` within a container
    environment, after we have run `make test-integration-setup` on this
    server.
    
    # Are these changes tested?
    Existing tests.
    
    # Are there any user-facing changes?
    
    No.
---
 Makefile | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 62c04250..cd6056b0 100644
--- a/Makefile
+++ b/Makefile
@@ -52,13 +52,17 @@ test-s3: # Run tests marked with s3, can add arguments with PYTEST_ARGS="-vv"
 	sh ./dev/run-minio.sh
 	poetry run pytest tests/ -m s3 ${PYTEST_ARGS}
 
-test-integration: ## Run all integration tests, can add arguments with PYTEST_ARGS="-vv"
+test-integration: | test-integration-setup test-integration-exec ## Run all integration tests, can add arguments with PYTEST_ARGS="-vv"
+
+test-integration-setup: # Prepare the environment for integration
 	docker compose -f dev/docker-compose-integration.yml kill
 	docker compose -f dev/docker-compose-integration.yml rm -f
 	docker compose -f dev/docker-compose-integration.yml up -d
 	sleep 10
 	docker compose -f dev/docker-compose-integration.yml cp ./dev/provision.py spark-iceberg:/opt/spark/provision.py
 	docker compose -f dev/docker-compose-integration.yml exec -T spark-iceberg ipython ./provision.py
+
+test-integration-exec:  # Execute integration tests, can add arguments with PYTEST_ARGS="-vv"
 	poetry run pytest tests/ -v -m integration ${PYTEST_ARGS}
 
 test-integration-rebuild: