[GitHub] spark pull request: [SPARK-10263] [ML] Add @Since annotation to ml...

[taishi-oss <gi...@git.apache.org>]

Github user taishi-oss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/8935#discussion_r46520868
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
    @@ -82,8 +82,11 @@ abstract class PipelineStage extends Params with Logging {
      * an identity transformer.
      */
     @Experimental
    -class Pipeline(override val uid: String) extends Estimator[PipelineModel] {
    +@Since("1.5.0")
    +class Pipeline(
    +    @Since("1.5.0") override val uid: String) extends Estimator[PipelineModel] {
     
    +  @Since("1.5.0")
    --- End diff --
    
    "git show" says Pipeline.this was introduced in v1.4.0.
    ```
    hiro [spark] (master) > git show v1.2.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "def this"           
    hiro [spark] (master) > git show v1.3.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "def this"
    hiro [spark] (master) > git show v1.4.0:mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala | grep "def this"
      def this() = this(Identifiable.randomUID("pipeline"))
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org