You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/17 21:02:02 UTC
[jira] [Commented] (CB-13791) Add Android support for a footer
close button.
[ https://issues.apache.org/jira/browse/CB-13791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16329465#comment-16329465 ]
ASF GitHub Bot commented on CB-13791:
-------------------------------------
dpa99c opened a new pull request #258: CB-13791: (android) Add Android support for a footer close button
URL: https://github.com/apache/cordova-plugin-inappbrowser/pull/258
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Adds support to Android for a footer close button similar to the "Done" button on iOS.
### What testing has been done on this change?
Manual testing as there's no currently no automated tests for platform-specific options.
I've tested all the possible combinations of the new `footer` and `footercolor` options with the related `closebuttoncaption` and `closebuttoncolor` options. The screenshots below illustrate the results:
`location=yes,footer=yes`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png"/>
`location=no,footer=yes`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png"/>
`location=yes,footer=yes,closebuttoncaption=Done`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png"/>
`location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#0000ff`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png"/>
`location=no,footer=yes,footercolor=#0000ff,closebuttoncaption=Done`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png"/>
`location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#0000ff`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png"/>
`location=no,footer=yes,footercolor=#CC000000,closebuttoncaption=Done,closebuttoncolor=#00FFFF`
<img width="300" src="https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png"/>
### Checklist
- [x ] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [x] Added automated test coverage as appropriate for this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add Android support for a footer close button.
> ----------------------------------------------
>
> Key: CB-13791
> URL: https://issues.apache.org/jira/browse/CB-13791
> Project: Apache Cordova
> Issue Type: Improvement
> Components: cordova-plugin-inappbrowser
> Environment: Android
> Reporter: Dave Alden
> Priority: Minor
> Labels: features, newbie
>
> Extending the work done in [PR #246|https://github.com/apache/cordova-plugin-inappbrowser/pull/246] under CB-13409, this adds support to Android for a footer close button similar to the "Done" button on iOS.
> The following options are added for Android:
> * *footer* - set to "yes" to show a close button in the footer similar to the iOS "Done" button.
> The close button will appear the same as for the header hence use _closebuttoncaption_ and _closebuttoncolor_ to set its properties.
> * *footercolor* - set to a valid hex color string, for example #00ff00 or #CC00ff00 (#aarrggbb) , and it will change the footer color from default. Only has effect if user has _footer_ set to "yes".
> Here are some example screenshots with the relevant options:
> _location=yes,footer=yes_
> !https://user-images.githubusercontent.com/2345062/33147006-2a602f88-cfbe-11e7-9580-438b07236400.png|width=300!
> _location=no,footer=yes_
> !https://user-images.githubusercontent.com/2345062/33147147-a60efaba-cfbe-11e7-8132-120179e8b43e.png|width=300!
> _location=yes,footer=yes,closebuttoncaption=Done_
> !https://user-images.githubusercontent.com/2345062/33147185-ca8d1e6c-cfbe-11e7-9646-0e1cea52abce.png|width=300!
> _location=no,footer=yes,closebuttoncaption=Done,closebuttoncolor=#0000ff_
> !https://user-images.githubusercontent.com/2345062/33147285-1aa7bc54-cfbf-11e7-9b9b-576f0d87ed9a.png|width=300!
> _location=no,footer=yes,footercolor=#0000ff,closebuttoncaption=Done_
> !https://user-images.githubusercontent.com/2345062/33147316-3ab511fe-cfbf-11e7-8b19-d1de80ad289e.png|width=300!
> _location=no,footer=yes,footercolor=#00ff00,closebuttoncaption=Done,closebuttoncolor=#0000ff_
> !https://user-images.githubusercontent.com/2345062/33147348-581b55c8-cfbf-11e7-9490-c61d83957079.png|width=300!
> _location=no,footer=yes,footercolor=#CC000000,closebuttoncaption=Done,closebuttoncolor=#00FFFF_
> !https://user-images.githubusercontent.com/2345062/33147377-6ec46c6a-cfbf-11e7-969e-a075142133c4.png|width=300!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org