You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/11/29 21:54:45 UTC
[royale-asjs] branch develop updated: jewel-scrollToIndex: remove
from the rest of places since we now do in
ListView.selectionChangeHandler()
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 7981ae2 jewel-scrollToIndex: remove from the rest of places since we now do in ListView.selectionChangeHandler()
7981ae2 is described below
commit 7981ae252066379e4b03b3f9805b9c3aa7ef15e5
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Sun Nov 29 22:54:36 2020 +0100
jewel-scrollToIndex: remove from the rest of places since we now do in ListView.selectionChangeHandler()
---
.../org/apache/royale/jewel/beads/controllers/ComboBoxController.as | 1 -
.../apache/royale/jewel/beads/controllers/ListKeyDownController.as | 4 +---
.../apache/royale/jewel/beads/controllers/TableKeyDownController.as | 4 +---
.../royale/jewel/beads/controllers/VirtualListKeyDownController.as | 4 +---
.../royale/jewel/beads/controls/textinput/SearchFilterForList.as | 5 -----
.../main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as | 3 +--
6 files changed, 4 insertions(+), 17 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ComboBoxController.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ComboBoxController.as
index a008f8e..ffac21f 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ComboBoxController.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ComboBoxController.as
@@ -174,7 +174,6 @@ package org.apache.royale.jewel.beads.controllers
var view:IListView = list.view as IListView;
var dataGroup:IItemRendererOwnerView = view.dataGroup;
var goToIndex:int = list.selectedIndex == -1 ? 0 : list.selectedIndex;
- list.scrollToIndex(goToIndex);
var ir:StyledDataItemRenderer = dataGroup.getItemRendererForIndex(goToIndex) as StyledDataItemRenderer;
COMPILE::JS
{
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
index a6863ee..f16b600 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/ListKeyDownController.as
@@ -153,9 +153,7 @@ package org.apache.royale.jewel.beads.controllers
var ir:IFocusable = listView.dataGroup.getItemRendererForIndex(listModel.selectedIndex) as IFocusable;
ir.setFocus();
- (listView as IScrollToIndexView).scrollToIndex(listModel.selectedIndex);
-
- sendEvent(listView.host, 'change');
+ sendEvent(listView.host, 'change');
}
}
}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/TableKeyDownController.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/TableKeyDownController.as
index 7e1bd66..d78ed69 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/TableKeyDownController.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/TableKeyDownController.as
@@ -140,9 +140,7 @@ package org.apache.royale.jewel.beads.controllers
// var ir:IFocusable = listView.dataGroup.getItemRendererForIndex(listModel.selectedIndex) as IFocusable;
// ir.setFocus();
- // (listView as IScrollToIndexView).scrollToIndex(listModel.selectedIndex);
-
- // sendEvent(listView.host, 'change');
+ // sendEvent(listView.host, 'change');
// }
}
}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/VirtualListKeyDownController.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/VirtualListKeyDownController.as
index cb164e5..6919638 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/VirtualListKeyDownController.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controllers/VirtualListKeyDownController.as
@@ -148,9 +148,7 @@ package org.apache.royale.jewel.beads.controllers
// var ir:IFocusable = listView.dataGroup.getItemRendererForIndex(listModel.selectedIndex) as IFocusable;
// ir.setFocus();
- // (listView as IScrollToIndexView).scrollToIndex(listModel.selectedIndex);
-
- // sendEvent(listView.host, 'change');
+ // sendEvent(listView.host, 'change');
// }
}
}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
index 66ca0bd..48a4b32 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
@@ -136,11 +136,6 @@ package org.apache.royale.jewel.beads.controls.textinput
var ir:IFocusable = (list.view as IListView).dataGroup.getItemRendererForIndex(list.selectedIndex) as IFocusable;
ir.setFocus();
- COMPILE::JS
- {
- scrollToIndex(list.selectedIndex);
- }
-
sendEvent(list, 'change');
}
}
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as
index 611afe4..a1279dd 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/views/ComboBoxView.as
@@ -214,8 +214,7 @@ package org.apache.royale.jewel.beads.views
//popup width needs to be set before position inside bounding client to work ok
_list.width = host.width;
- _list.scrollToIndex(_list.selectedIndex);
-
+
COMPILE::JS
{
// Fix temporary: when soft keyboard opens in ios devices browser is not resized, so popup gets under the keyboard