[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #712: [#711] feat(netty): Add Netty port information for Shuffle Server

["zuston (via GitHub)" <gi...@apache.org>]

zuston commented on code in PR #712:
URL: https://github.com/apache/incubator-uniffle/pull/712#discussion_r1134824155


##########
common/src/main/java/org/apache/uniffle/common/ClientType.java:
##########
@@ -18,5 +18,6 @@
 package org.apache.uniffle.common;
 
 public enum ClientType {
-  GRPC
+  GRPC,
+  GRPC_NETTY

Review Comment:
   I think current implementation is a mixed way, only main data transfer api will be changed to netty proto. So GRPC_NETTY is reasonable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org