[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #11497: Use equals instead of == to compare strings (#11462)

[GitBox <gi...@apache.org>]

michaeljmarshall commented on a change in pull request #11497:
URL: https://github.com/apache/pulsar/pull/11497#discussion_r686313389



##########
File path: managed-ledger/src/test/java/org/apache/bookkeeper/test/ZooKeeperUtil.java
##########
@@ -116,7 +116,7 @@ public void startServer(String path) throws Exception {
         // create a zookeeper client
         LOG.debug("Instantiate ZK Client");
         zkc = ZooKeeperClient.newBuilder().connectString(getZooKeeperConnectString()).build();
-        if (path != "") {
+        if (StringUtils.isNotEmpty(path)) {

Review comment:
       Sorry for the back and forth here @skyguard1. I only recommended using `StringUtils.isNotEmpty` because it is used elsewhere in the project. `! "".equals(path)` certainly works, too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org