You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/08/29 09:32:08 UTC
[GitHub] [airflow] potiuk opened a new pull request #17890: Add August 2021 Provider's documentation
potiuk opened a new pull request #17890:
URL: https://github.com/apache/airflow/pull/17890
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17890:
URL: https://github.com/apache/airflow/pull/17890#issuecomment-907760864
This time we will release almost all the providers (but vast majority of them just contains the new "connection-type" in provider-info that will allow to optimise importing of connections in Airflow 2.2 - it's fully backwards compatible with 2.1 and it's tested automatically for connection discovery so it's safe to release it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on a change in pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
eladkal commented on a change in pull request #17890:
URL: https://github.com/apache/airflow/pull/17890#discussion_r698246623
##########
File path: airflow/providers/airbyte/CHANGELOG.rst
##########
@@ -19,13 +19,27 @@
Changelog
---------
+2.1.1
+.....
+
+Misc
+~~~~
+
+* ``Optimise connection importing for Airflow 2.2.0``
+
+.. Below changes are excluded from the changelog. Move them to
+ appropriate section above if needed. Do not delete the lines(!):
+ * ``Fix messed-up changelog in 3 providers (#17380)``
+ * ``Update description about the new ''connection-types'' provider meta-data (#17767)``
+ * ``Import Hooks lazily individually in providers manager (#17682)``
+
2.1.0
.....
Bug Fixes
~~~~~~~~~
-* ``Fixed wrongly escaped characters in amazon's changelog (#17020)``
+* ``Fixed wrongly escaped characters in amazon's changelog (#17020)``
Review comment:
mmm this description is kinda weird for the airbyte provider.
https://github.com/apache/airflow/pull/17020 changed files in several providers.
I think It would be better change all occurrences of:
`Fixed wrongly escaped characters in amazon's changelog (#17020)`
with
`Fixed wrongly escaped characters in changelog (#17020)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #17890:
URL: https://github.com/apache/airflow/pull/17890#issuecomment-908086143
I will update and merge it after #17900 -> I want to use the opportunity that we release nearly all providers due to "2.2.0" upcoming optimisation to fix all deprecation warnings in examples and code of the providers!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17890:
URL: https://github.com/apache/airflow/pull/17890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #17890:
URL: https://github.com/apache/airflow/pull/17890#discussion_r698279243
##########
File path: airflow/providers/airbyte/CHANGELOG.rst
##########
@@ -19,13 +19,27 @@
Changelog
---------
+2.1.1
+.....
+
+Misc
+~~~~
+
+* ``Optimise connection importing for Airflow 2.2.0``
+
+.. Below changes are excluded from the changelog. Move them to
+ appropriate section above if needed. Do not delete the lines(!):
+ * ``Fix messed-up changelog in 3 providers (#17380)``
+ * ``Update description about the new ''connection-types'' provider meta-data (#17767)``
+ * ``Import Hooks lazily individually in providers manager (#17682)``
+
2.1.0
.....
Bug Fixes
~~~~~~~~~
-* ``Fixed wrongly escaped characters in amazon's changelog (#17020)``
+* ``Fixed wrongly escaped characters in amazon's changelog (#17020)``
Review comment:
Actually .... it should not be there at all :). It's the kind of change that should go to "ignored" part. below. I will move it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #17890:
URL: https://github.com/apache/airflow/pull/17890#issuecomment-908079443
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #17890: Add August 2021 Provider's documentation
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #17890:
URL: https://github.com/apache/airflow/pull/17890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org