You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by GitBox <gi...@apache.org> on 2020/08/10 05:34:24 UTC
[GitHub] [karaf] jbonofre commented on a change in pull request #1142: [KARAF-6797] More detailed description of the JAAS command options fo…
jbonofre commented on a change in pull request #1142:
URL: https://github.com/apache/karaf/pull/1142#discussion_r467694902
##########
File path: jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java
##########
@@ -35,14 +35,14 @@
@Service
public class ManageRealmCommand extends JaasCommandSupport {
- @Option(name = "--realm", description = "JAAS Realm", required = false, multiValued = false)
+ @Option(name = "--realm", description = "JAAS Realm. Must be combined with --module", required = false, multiValued = false)
@Completion(RealmCompleter.class)
String realmName;
@Option(name = "--index", description = "Realm Index", required = false, multiValued = false)
Review comment:
I would add the "must be combined" statement here and leave realm option description as it is.
##########
File path: jaas/command/src/main/java/org/apache/karaf/jaas/command/ManageRealmCommand.java
##########
@@ -35,14 +35,14 @@
@Service
public class ManageRealmCommand extends JaasCommandSupport {
- @Option(name = "--realm", description = "JAAS Realm", required = false, multiValued = false)
+ @Option(name = "--realm", description = "JAAS Realm. Must be combined with --module", required = false, multiValued = false)
Review comment:
That's not fully correct. Realm can be combined with module, but also with index.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org