[GitHub] [commons-vfs] grimreaper commented on a change in pull request #76: [commons-vfs] clean up tests and simplify assertions

[GitBox <gi...@apache.org>]

grimreaper commented on a change in pull request #76: [commons-vfs] clean up tests and simplify assertions
URL: https://github.com/apache/commons-vfs/pull/76#discussion_r361853675
 
 

 ##########
 File path: commons-vfs2/src/test/java/org/apache/commons/AbstractVfsTestCase.java
 ##########
 @@ -136,7 +118,7 @@ public static File getTestDirectory(final String name) {
     /**
      * Makes a file canonical
      */
-    public static File getCanonicalFile(final File file) {
+    private static File getCanonicalFile(final File file) {
 
 Review comment:
   I find it makes it easier to detect unused code along with all the other typical reasons to default to private. That said I don't feel strongly about this so I'll just revert.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services