[PR] sanitize: drop Airflow remnants; synthesize fictional adopter for tests [airflow-steward]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk opened a new pull request, #7:
URL: https://github.com/apache/airflow-steward/pull/7

   ## Summary
   
   Comprehensive sanitization pass — the framework now talks about itself in fully project-agnostic terms; the Airflow-specific scaffolding (test fixture, package-naming infix, hardcoded CVE-record fields) is gone.
   
   **33 files changed, +519 −562 across two commits.** All 139 tests pass; all prek hooks green.
   
   ## Two commits
   
   ### Commit 1 — `docs+code: sanitize Airflow remnants; synthesize fictional adopter for tests`
   
   - **Tier 1 (top-level docs):** README, CONTRIBUTING, new-members-onboarding, projects/_template/*.md — drop hardcoded Airflow scope-label lists, board URLs, `projects/airflow/` references; replace with `<tracker>` / `<project-config>` placeholders.
   - **Tier 2 (skill files + tool docs):** ~30 substitutions across 7 SKILL.md files and tools/{gmail,github,ponymail}/*.md. `airflow-s` standalone references → `<tracker>`; "Apache Airflow PMC" → "the project's PMC"; "the Airflow Security Model" → "the project's security model"; etc.
   - **Tier 3 (`cve_json.py` config-driven refactor):** three hardcoded Airflow values were bypassing the otherwise-config-driven design — `wrap_cve_record`'s `CNA_private` envelope (`projecturl`/`owner`/`userslist`), `build_references`' URL filter, and `resolve_title`'s strip regex. All three now config-driven via a new `[cna_private]` section + `TRACKER_FILTER_TOKEN` + `TITLE_STRIP_RE` constants. Also removed an orphaned `SKILL_SOURCE_URL` assignment that was overriding the config-loaded value.
   - **Q1(b):** `tests/fixtures/cve-json-config.toml` rewritten as a fictional **"Apache Example"** project; 135 sed-driven assertion updates in `test_generate_cve_json.py`.
   - **Q2:** `pyproject.toml` package name `apache-airflow-steward` → `apache-steward`.
   
   ### Commit 2 — `sanitize: rename 'provider' → 'project'; switch test data to fictional names`
   
   The first commit left two adopter-shape leaks the user caught:
   
   - **Terminology:** the codebase used "provider" throughout — a term inherited from Airflow's `apache-airflow-providers-*` layout. Renamed to "project" everywhere (constants, locals, regex named group, comments, config keys, package-name infix `-providers-` → `-project-`). Untouched: the upstream CVE 5.x schema field `providerMetadata`.
   - **Fictional test data:** the test fixture's display map still carried real ASF / external software names (`elasticsearch`, `snowflake`, `cncf-kubernetes`, `opensearch`, `smtp`). Replaced with placeholders that cover the same test paths:
   
     | Old (real) | New (fictional) | Tests |
     |---|---|---|
     | `cncf-kubernetes` → `CNCF Kubernetes` | `acme-xyz` → `Acme XYZ` | multi-word + acronym |
     | `elasticsearch` → `Elasticsearch` | `foo` → `Foo` | single-word identity |
     | `opensearch` → `OpenSearch` | `kerfluffle` → `Kerfluffle` | single-word mixed-case |
     | `smtp` → `SMTP` | `xyz` → `XYZ` | single-word acronym |
     | `snowflake` → `Snowflake` | `bar` → `Bar` | single-word identity |
     | (none) | `pop-corn` → `Pop Corn` | multi-word title-case |
   
     `brand-new` / `madeup-widget` (unmapped-fallback test names) were already fictional, kept.
   
   ## Out of scope (follow-up PRs)
   
   Airflow-specific procedural content still in `sync-security-issue/SKILL.md` and `allocate-cve/SKILL.md` (release-train naming, scope-label sets, milestone formats, title-normalization regex example) — needs extraction to per-project config; separate PR.
   
   ## Test plan
   
   - ✅ 139 tests pass (134 generate-cve-json, 58 oauth-draft).
   - ✅ `prek run --all-files` passes (16 hooks).
   - ✅ `zizmor` clean.
   - ✅ `grep -i provider` against the source/tests yields only the upstream `providerMetadata` schema reference.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] sanitize: drop Airflow remnants; synthesize fictional adopter for tests [airflow-steward]

["potiuk (via GitHub)" <gi...@apache.org>]

potiuk merged PR #7:
URL: https://github.com/apache/airflow-steward/pull/7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org