You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/12/22 04:50:10 UTC

[GitHub] [airflow] ericpp commented on a change in pull request #20433: Moved `wait_for_state` inside context to ensure an active Tableau connection

ericpp commented on a change in pull request #20433:
URL: https://github.com/apache/airflow/pull/20433#discussion_r773597331



##########
File path: airflow/providers/tableau/operators/tableau.py
##########
@@ -107,6 +107,7 @@ def execute(self, context: dict) -> str:
             error_message = f'Method not found! Available methods for {self.resource}: {available_methods}'
             raise AirflowException(error_message)
 
+        job_id = ""

Review comment:
       I added it in case the `TableauHook` context fails and it's left undefined. But I suppose if that were to happen, it would throw an exception and wouldn't reach `return job_id` anyway. I can remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org