You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/08/03 22:57:11 UTC

[jira] [Commented] (OOZIE-1782) Workflow path not found is thrown as SC_UNAUTHORIZED

    [ https://issues.apache.org/jira/browse/OOZIE-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14084129#comment-14084129 ] 

Hadoop QA commented on OOZIE-1782:
----------------------------------

Testing JIRA OOZIE-1782

Cleaning local git workspace

----------------------------

{color:green}+1 PATCH_APPLIES{color}
{color:green}+1 CLEAN{color}
{color:green}+1 RAW_PATCH_ANALYSIS{color}
.    {color:green}+1{color} the patch does not introduce any @author tags
.    {color:green}+1{color} the patch does not introduce any tabs
.    {color:green}+1{color} the patch does not introduce any trailing spaces
.    {color:green}+1{color} the patch does not introduce any line longer than 132
.    {color:green}+1{color} the patch does adds/modifies 1 testcase(s)
{color:green}+1 RAT{color}
.    {color:green}+1{color} the patch does not seem to introduce new RAT warnings
{color:green}+1 JAVADOC{color}
.    {color:green}+1{color} the patch does not seem to introduce new Javadoc warnings
{color:green}+1 COMPILE{color}
.    {color:green}+1{color} HEAD compiles
.    {color:green}+1{color} patch compiles
.    {color:green}+1{color} the patch does not seem to introduce new javac warnings
{color:green}+1 BACKWARDS_COMPATIBILITY{color}
.    {color:green}+1{color} the patch does not change any JPA Entity/Colum/Basic/Lob/Transient annotations
.    {color:green}+1{color} the patch does not modify JPA files
{color:green}+1 TESTS{color}
.    Tests run: 1505
{color:green}+1 DISTRO{color}
.    {color:green}+1{color} distro tarball builds with the patch 

----------------------------
{color:green}*+1 Overall result, good!, no -1s*{color}


The full output of the test-patch run is available at

.   https://builds.apache.org/job/oozie-trunk-precommit-build/1456/

> Workflow path not found is thrown as SC_UNAUTHORIZED
> ----------------------------------------------------
>
>                 Key: OOZIE-1782
>                 URL: https://issues.apache.org/jira/browse/OOZIE-1782
>             Project: Oozie
>          Issue Type: Bug
>            Reporter: Purshotam Shah
>            Assignee: Purshotam Shah
>         Attachments: OOZIE-1782-V1.patch, OOZIE-1782-V2.patch
>
>
> {code:java} 
> AuthorizationService.java
> ....
> Path path = new Path(appPath);
> try {
> 	if (!fs.exists(path)) {
>     	incrCounter(INSTR_FAILED_AUTH_COUNTER, 1);
>         throw new AuthorizationException(ErrorCode.E0504, appPath);
>     }
> BaseJobServlet.java 
> ......
> if (wfPath != null) {
>                 auth.authorizeForApp(user, acl, wfPath, "workflow.xml", conf);
>             }
>             else if (coordPath != null){
>                 auth.authorizeForApp(user, acl, coordPath, "coordinator.xml", conf);
>             }
>             else if (bundlePath != null){
>                 auth.authorizeForApp(user, acl, bundlePath, "bundle.xml", conf);
>             }
>         }
>         catch (AuthorizationException ex) {
>             XLog.getLog(BaseJobServlet.class).info("AuthorizationException ", ex);
>             throw new XServletException(HttpServletResponse.SC_UNAUTHORIZED, ex);
>         }
> {code} 
> Path not found should be a SC_BAD_REQUEST not SC_UNAUTHORIZED.



--
This message was sent by Atlassian JIRA
(v6.2#6252)