[GitHub] [nifi] gresockj commented on a change in pull request #5832: NIFI-9754: Introduced VersionedExternalFlow

[GitBox <gi...@apache.org>]

gresockj commented on a change in pull request #5832:
URL: https://github.com/apache/nifi/pull/5832#discussion_r818969639



##########
File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/flow/StandardStatelessDataflowFactory.java
##########
@@ -284,6 +282,83 @@ public EventReporter getEventReporter() {
         }
     }
 
+    // TODO: Create util that handles this.

Review comment:
       Is this necessary to stay here?

##########
File path: nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/flow/StandardStatelessDataflowFactory.java
##########
@@ -88,17 +87,16 @@
 import java.util.List;
 import java.util.Optional;
 
-public class StandardStatelessDataflowFactory implements StatelessDataflowFactory<VersionedFlowSnapshot> {
+public class StandardStatelessDataflowFactory implements StatelessDataflowFactory {
     private static final Logger logger = LoggerFactory.getLogger(StandardStatelessDataflowFactory.class);
 
-    @Override
-    public StatelessDataflow createDataflow(final StatelessEngineConfiguration engineConfiguration, final DataflowDefinition<VersionedFlowSnapshot> dataflowDefinition,
+
+    // TODO: Support both VersionedExternalFlow and VersionedFlowSnapshot...

Review comment:
       Should this TODO be left here?

##########
File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/groups/ProcessGroupSynchronizer.java
##########
@@ -29,7 +29,7 @@
      * @param proposedSnapshot the proposed/desired state for the process group

Review comment:
       Would you like to take the opportunity to rename this (and below) as `proposedFlow` or something?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org