You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by "Kashatlast2 (via GitHub)" <gi...@apache.org> on 2023/04/24 18:20:33 UTC

[GitHub] [trafficcontrol] Kashatlast2 opened a new pull request, #7461: Api contract phys locations

Kashatlast2 opened a new pull request, #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461

   <!--
   Thank you for contributing! Please be sure to read our contribution guidelines: https://github.com/apache/trafficcontrol/blob/master/CONTRIBUTING.md
   If this closes or relates to an existing issue, please reference it using one of the following:
   
   Closes: #ISSUE
   Related: #ISSUE
   
   If this PR fixes a security vulnerability, DO NOT submit! Instead, contact
   the Apache Traffic Control Security Team at security@trafficcontrol.apache.org and follow the
   guidelines at https://apache.org/security regarding vulnerability disclosure.
   -->
   
   Adding API Contract Test Case for phys_locations endpoint.
   <!-- **^ Add meaningful description above** --><hr/>
   
   
   ## Which Traffic Control components are affected by this PR?
   <!-- Please delete all components from this list that are NOT affected by this PR.
   Feel free to add the name of a tool or script that is affected but not on the list.
   -->
   - Traffic Ops Test
   
   
   ## What is the best way to verify this PR?
   
   Step 1 : Install requirements
   pip install -r requirements.txt
   
   Step 2 : To execute divisions API Contract Testcase , navigate to traffic_ops/testing/api_contract/v4
   pytest --to-user Username --to-password Password --to-url URL --config Config Path --request-template Request template --response-template Response template test_phys_locations.py
   
   Note: Config, Request template and response template paths are optional. 
   
   ## PR submission checklist
   - [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
   
   <!--
   Licensed to the Apache Software Foundation (ASF) under one
   or more contributor license agreements.  See the NOTICE file
   distributed with this work for additional information
   regarding copyright ownership.  The ASF licenses this file
   to you under the Apache License, Version 2.0 (the
   "License"); you may not use this file except in compliance
   with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
   Unless required by applicable law or agreed to in writing,
   software distributed under the License is distributed on an
   "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
   KIND, either express or implied.  See the License for the
   specific language governing permissions and limitations
   under the License.
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7461: Api contract phys locations

Posted by "ericholguin (via GitHub)" <gi...@apache.org>.
ericholguin commented on code in PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461#discussion_r1192779717


##########
traffic_control/clients/python/trafficops/tosession.py:
##########
@@ -1361,6 +1361,17 @@ def get_physical_locations(self, query_params=None):
 		:raises: Union[LoginError, OperationError]
 		"""
 
+	@api_request('post', 'phys_locations', ('3.0', '4.0', '4.1', '5.0'))

Review Comment:
   Yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ocket8888 commented on a diff in pull request #7461: Api contract phys locations

Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 commented on code in PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461#discussion_r1192707687


##########
traffic_control/clients/python/trafficops/tosession.py:
##########
@@ -1361,6 +1361,17 @@ def get_physical_locations(self, query_params=None):
 		:raises: Union[LoginError, OperationError]
 		"""
 
+	@api_request('post', 'phys_locations', ('3.0', '4.0', '4.1', '5.0'))

Review Comment:
   Missing API version 3.1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] mitchell852 commented on pull request #7461: Api contract phys locations

Posted by "mitchell852 (via GitHub)" <gi...@apache.org>.
mitchell852 commented on PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461#issuecomment-1553345674

   @gokulakrishnansvm - can you make the PR title more descriptive. maybe something like "Added Api contract tests for phys locations"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ericholguin commented on a diff in pull request #7461: Api contract phys locations

Posted by "ericholguin (via GitHub)" <gi...@apache.org>.
ericholguin commented on code in PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461#discussion_r1192764293


##########
traffic_ops/testing/api_contract/v4/request_template.json:
##########
@@ -1,71 +1,75 @@
 {
-    "cdns": [
-        {
-            "name": "test",
-            "domainName": "quest",
-            "dnssecEnabled": false
-        }
-    ],
-    "cachegroup": [
-        {
-            "name": "test",
-            "shortName": "test",
-            "latitude": 38.897663,
-            "longitude": -77.036574,
-            "fallbackToClosest": true,
-            "localizationMethods": [
-                "DEEP_CZ",
-                "CZ",
-                "GEO"
-            ],
-            "typeId": 23
-        }
-    ],
-    "parameters": [
-        {
-            "name": "test",
-            "value": "quest",
-            "configFile": "records.config",
-            "secure": false
-        }
-    ],
-    "roles": [
-        {
-            "name": "test",
-            "description": "quest"
-        }
-    ],
-    "profiles": [
-        {
-            "name": "test",
-            "description": "A test profile for API examples",
-            "cdn": 2,
-            "type": "UNK_PROFILE",
-            "routingDisabled": true
-        }
-    ],
-    "tenants": [
-        {
-            "active": true,
-            "name": "test",
-            "parentId": 1
-        }
-    ],
-    "server_capabilities": [
-        {
-            "name": "RAM"
-        }
-    ],
-    "divisions":[
-        {
-            "name":"test"
-        }
-    ],
-    "regions": [
-		    {
+	"cdns": [
+		{
+			"name": "test",
+			"domainName": "quest",
+			"dnssecEnabled": false
+		}
+	],
+	"cachegroup": [
+		{
+			"name": "test",
+			"shortName": "test",
+			"latitude": 38.897663,
+			"longitude": -77.036574,
+			"fallbackToClosest": true,
+			"localizationMethods": [
+				"DEEP_CZ",
+				"CZ",
+				"GEO"
+			],
+			"typeId": 23
+		}
+	],
+	"parameters": [
+		{
+			"name": "test",
+			"value": "quest",
+			"configFile": "records.config",
+			"secure": false
+		}
+	],
+	"roles": [
+		{
+			"name": "test",
+			"description": "quest"
+		}
+	],
+	"profiles": [
+		{
+			"name": "test",
+			"description": "A test profile for API examples",
+			"cdn": 2,
+			"type": "UNK_PROFILE",
+			"routingDisabled": true
+		}
+
+	],
+	"divisions":[
+		{
+			"name":"test"
+		}
+	],
+	"regions": [
+		{
 			"divisionName": "Quebec",
-			"division": 1,
-			"name": "Montreal"
-    		}
-   	]
+        	"division": 1,
+        	"name": "Montreal"
+		}
+	],
+	"phys_locations": [
+		{
+			"address": "Buckingham Palace",
+			"city": "London",
+			"comments": "Buckingham Palace",
+			"email": "steve.kingstone@royal.gsx.gov.uk",
+			"name": "test",
+			"phone": "0-843-816-6276",
+			"poc": "Her Majesty The Queen Elizabeth Alexandra Mary Windsor II",
+			"regionId": 3,
+			"shortName": "test",
+			"state": "Westminster",
+			"zip": "SW1A 1AA"
+		}
+	]		

Review Comment:
   Tests are failing because you deleted the server capabilities and tenants objects from here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] ocket8888 merged pull request #7461: Api contract phys locations

Posted by "ocket8888 (via GitHub)" <gi...@apache.org>.
ocket8888 merged PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [trafficcontrol] Kashatlast2 commented on a diff in pull request #7461: Api contract phys locations

Posted by "Kashatlast2 (via GitHub)" <gi...@apache.org>.
Kashatlast2 commented on code in PR #7461:
URL: https://github.com/apache/trafficcontrol/pull/7461#discussion_r1192718333


##########
traffic_control/clients/python/trafficops/tosession.py:
##########
@@ -1361,6 +1361,17 @@ def get_physical_locations(self, query_params=None):
 		:raises: Union[LoginError, OperationError]
 		"""
 
+	@api_request('post', 'phys_locations', ('3.0', '4.0', '4.1', '5.0'))

Review Comment:
   None of the other phys_locations functions have 3.1. Should I add it anyway?



##########
traffic_ops/testing/api_contract/v4/request_template.json:
##########
@@ -1,71 +1,75 @@
 {
-    "cdns": [
-        {
-            "name": "test",
-            "domainName": "quest",
-            "dnssecEnabled": false
-        }
-    ],
-    "cachegroup": [
-        {
-            "name": "test",
-            "shortName": "test",
-            "latitude": 38.897663,
-            "longitude": -77.036574,
-            "fallbackToClosest": true,
-            "localizationMethods": [
-                "DEEP_CZ",
-                "CZ",
-                "GEO"
-            ],
-            "typeId": 23
-        }
-    ],
-    "parameters": [
-        {
-            "name": "test",
-            "value": "quest",
-            "configFile": "records.config",
-            "secure": false
-        }
-    ],
-    "roles": [
-        {
-            "name": "test",
-            "description": "quest"
-        }
-    ],
-    "profiles": [
-        {
-            "name": "test",
-            "description": "A test profile for API examples",
-            "cdn": 2,
-            "type": "UNK_PROFILE",
-            "routingDisabled": true
-        }
-    ],
-    "tenants": [
-        {
-            "active": true,
-            "name": "test",
-            "parentId": 1
-        }
-    ],
-    "server_capabilities": [
-        {
-            "name": "RAM"
-        }
-    ],
-    "divisions":[
-        {
-            "name":"test"
-        }
-    ],
-    "regions": [
-		    {
+	"cdns": [
+		{
+			"name": "test",
+			"domainName": "quest",
+			"dnssecEnabled": false
+		}
+	],
+	"cachegroup": [
+		{
+			"name": "test",
+			"shortName": "test",
+			"latitude": 38.897663,
+			"longitude": -77.036574,
+			"fallbackToClosest": true,
+			"localizationMethods": [
+				"DEEP_CZ",
+				"CZ",
+				"GEO"
+			],
+			"typeId": 23
+		}
+	],
+	"parameters": [
+		{
+			"name": "test",
+			"value": "quest",
+			"configFile": "records.config",
+			"secure": false
+		}
+	],
+	"roles": [
+		{
+			"name": "test",
+			"description": "quest"
+		}
+	],
+	"profiles": [
+		{
+			"name": "test",
+			"description": "A test profile for API examples",
+			"cdn": 2,
+			"type": "UNK_PROFILE",
+			"routingDisabled": true
+		}
+
+	],
+	"divisions":[
+		{
+			"name":"test"
+		}
+	],
+	"regions": [
+		{
 			"divisionName": "Quebec",
-			"division": 1,
-			"name": "Montreal"
-    		}
-   	]
+        	"division": 1,
+        	"name": "Montreal"
+		}
+	],
+	"phys_locations": [
+		{
+			"address": "Buckingham Palace",
+			"city": "London",
+			"comments": "Buckingham Palace",
+			"email": "steve.kingstone@royal.gsx.gov.uk",
+			"name": "test",
+			"phone": "0-843-816-6276",
+			"poc": "Her Majesty The Queen Elizabeth Alexandra Mary Windsor II",
+			"regionId": 3,
+			"shortName": "test",
+			"state": "Westminster",
+			"zip": "SW1A 1AA"
+		}
+	]		

Review Comment:
   added them back



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org