You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Peter Bacsko via Review Board <no...@reviews.apache.org> on 2018/07/11 11:50:39 UTC

Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------

Review request for oozie, András Piros and Robert Kanter.


Repository: oozie-git


Description
-------

Still just a POC.

Tests are almost completely missing.


Diffs
-----

  core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableAccess.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5 
  core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c 
  core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f 


Diff: https://reviews.apache.org/r/67885/diff/1/


Testing
-------

Executed TestCallableQueueService which passed completely.


Thanks,

Peter Bacsko


Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------

(Updated júl. 31, 2018, 11 de)


Review request for oozie, András Piros and Robert Kanter.


Changes
-------

Added new tests to TestCallableQueueService


Repository: oozie-git


Description
-------

Still just a POC.

Tests are almost completely missing.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableAccess.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5 
  core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c 
  core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f 


Diff: https://reviews.apache.org/r/67885/diff/4/

Changes: https://reviews.apache.org/r/67885/diff/3-4/


Testing
-------

Executed TestCallableQueueService which passed completely.


Thanks,

Peter Bacsko


Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------

(Updated júl. 13, 2018, 10:05 de)


Review request for oozie, András Piros and Robert Kanter.


Repository: oozie-git


Description
-------

Still just a POC.

Tests are almost completely missing.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableAccess.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5 
  core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c 
  core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f 


Diff: https://reviews.apache.org/r/67885/diff/3/

Changes: https://reviews.apache.org/r/67885/diff/2-3/


Testing
-------

Executed TestCallableQueueService which passed completely.


Thanks,

Peter Bacsko


Re: Review Request 67885: POC: OOZIE-3160 PriorityDelayQueue put()/take() can cause significant CPU load due to busy waiting

Posted by Peter Bacsko via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67885/
-----------------------------------------------------------

(Updated júl. 13, 2018, 10:03 de)


Review request for oozie, András Piros and Robert Kanter.


Changes
-------

Fixed some bugs


Repository: oozie-git


Description
-------

Still just a POC.

Tests are almost completely missing.


Diffs (updated)
-----

  core/src/main/java/org/apache/oozie/service/AsyncXCommandExecutor.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableAccess.java PRE-CREATION 
  core/src/main/java/org/apache/oozie/service/CallableQueueService.java ef8d58da5 
  core/src/main/java/org/apache/oozie/util/PriorityDelayQueue.java 75c20698c 
  core/src/test/java/org/apache/oozie/service/TestCallableQueueService.java 9c2a11d6f 


Diff: https://reviews.apache.org/r/67885/diff/2/

Changes: https://reviews.apache.org/r/67885/diff/1-2/


Testing
-------

Executed TestCallableQueueService which passed completely.


Thanks,

Peter Bacsko