[jira] [Comment Edited] (EAGLE-984) Potential null dereference in SimpleWindowCounter#poll()

["Ted Yu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/EAGLE-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15980976#comment-15980976 ] 

Ted Yu edited comment on EAGLE-984 at 11/5/17 9:51 AM:
-------------------------------------------------------

I can work on this once EAGLE-985 is integrated.


was (Author: yuzhihong@gmail.com):
I can work on this once EAGLE-985 is integrated .

> Potential null dereference in SimpleWindowCounter#poll()
> --------------------------------------------------------
>
>                 Key: EAGLE-984
>                 URL: https://issues.apache.org/jira/browse/EAGLE-984
>             Project: Eagle
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>             Fix For: v0.5.1
>
>
> Here is related code:
> {code}
>     public Tuple2<Long, Long> poll() {
>         long oldestTimestamp = timeQueue.poll();
>         Tuple2<Long, Long> pair = new Tuple2<>(oldestTimestamp, counter.get(oldestTimestamp));
> {code}
> We should check the return value from timeQueue.poll() before casting to long.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)