You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/05/28 16:34:16 UTC
[GitHub] [trafficcontrol] mattjackson220 opened a new pull request #4730: WIP - Database migration 2 for multiple interfaces
mattjackson220 opened a new pull request #4730:
URL: https://github.com/apache/trafficcontrol/pull/4730
<!--
************ STOP!! ************
If this Pull Request is intended to fix a security vulnerability, DO NOT submit it! Instead, contact
the Apache Software Foundation Security Team at security@trafficcontrol.apache.org and follow the
guidelines at https://www.apache.org/security/ regarding vulnerability disclosure.
-->
## What does this PR (Pull Request) do?
<!-- Explain the changes you made here. If this fixes an Issue, identify it by
replacing the text in the checkbox item with the Issue number e.g.
- [x] This PR fixes #9001 OR is not related to any Issue
^ This will automatically close Issue number 9001 when the Pull Request is
merged (The '#' is important).
Be sure you check the box properly, see the "The following criteria are ALL
met by this PR" section for details.
-->
- [x] This PR fixes #4620 <!-- You can check for an issue here: https://github.com/apache/trafficcontrol/issues -->
This is the second database migration for allowing multiple interfaces. It removes redundant columns from the server table that have been moved previously to the ip_address and interface tables.
This is labeled as a WIP for now because it needs to wait to be merged until the issues listed in issue 4620 have all been closed.
## Which Traffic Control components are affected by this PR?
<!-- Please delete all components from this list that are NOT affected by this
Pull Request. Also, feel free to add the name of a tool or script that is
affected but not on the list.
Additionally, if this Pull Request does NOT affect documentation, please
explain why documentation is not required. -->
- Traffic Ops
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your Pull Request. If
it includes tests (and most should), outline here the steps needed to run the
tests. If not, lay out the manual testing procedure and please explain why
tests are unnecessary for this Pull Request. -->
Run the db migration and verify that it runs successfully and the columns have been removed. verify that the unit and API tests still run successfully
Run the rollback script and verify that the data has been populated correctly. Run the tests and make sure they work still.
## If this is a bug fix, what versions of Traffic Control are affected?
<!-- If this PR fixes a bug, please list here all of the affected versions - to
the best of your knowledge. It's also pretty helpful to include a commit hash
of where 'master' is at the time this PR is opened (if it affects master),
because what 'master' means will change over time. For example, if this PR
fixes a bug that's present in master (at commit hash '1df853c8'), in v4.0.0,
and in the current 4.0.1 Release candidate (e.g. RC1), then this list would
look like:
- master (1df853c8)
- 4.0.0
- 4.0.1 (RC1)
If you don't know what other versions might have this bug, AND don't know how
to find the commit hash of 'master', then feel free to leave this section
blank (or, preferably, delete it entirely).
-->
## The following criteria are ALL met by this PR
<!-- Check the boxes to signify that the associated statement is true. To
"check a box", replace the space inside of the square brackets with an 'x'.
e.g.
- [ x] <- Wrong
- [x ] <- Wrong
- [] <- Wrong
- [*] <- Wrong
- [x] <- Correct!
-->
No tests, docs, or CHANGELOG updates are necessary since it is a data migration and database update.
- [x] This PR includes tests OR I have explained why tests are unnecessary
- [x] This PR includes documentation OR I have explained why documentation is unnecessary
- [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
- [x] This PR includes any and all required license headers
- [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
<!-- If you would like to include any additional information on the PR for
potential reviewers please put it here.
Some examples of this would be:
- Before and after screenshots/gifs of the Traffic Portal if it is affected
- Links to other dependent Pull Requests
- References to relevant context (e.g. new/updates to dependent libraries,
mailing list records, blueprints)
Feel free to leave this section blank (or, preferably, delete it entirely).
-->
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4730: Database migration 2 for multiple interfaces
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4730:
URL: https://github.com/apache/trafficcontrol/pull/4730#discussion_r452494195
##########
File path: traffic_ops/app/db/migrations/20200607000000_remove_redundancy.sql
##########
@@ -0,0 +1,70 @@
+/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+-- +goose Up
+ALTER TABLE server DROP CONSTRAINT need_at_least_one_ip;
+ALTER TABLE server DROP CONSTRAINT need_gateway_if_ip;
+ALTER TABLE server DROP CONSTRAINT need_netmask_if_ip;
+
+ALTER TABLE server DROP COLUMN interface_name;
+ALTER TABLE server DROP COLUMN ip_address;
+ALTER TABLE server DROP COLUMN ip_netmask;
+ALTER TABLE server DROP COLUMN ip_gateway;
+ALTER TABLE server DROP COLUMN ip6_address;
+ALTER TABLE server DROP COLUMN ip6_gateway;
+ALTER TABLE server DROP COLUMN interface_mtu;
+ALTER TABLE server DROP COLUMN ip_address_is_service;
+ALTER TABLE server DROP COLUMN ip6_address_is_service;
+
+
+-- +goose Down
+ALTER TABLE server ADD COLUMN interface_name text DEFAULT '' NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_netmask text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN interface_mtu bigint DEFAULT '9000'::bigint NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address_is_service boolean DEFAULT true;
+ALTER TABLE server ADD COLUMN ip6_address_is_service boolean DEFAULT true;
+
+ALTER TABLE server ADD CONSTRAINT need_at_least_one_ip CHECK (ip_address IS NOT NULL OR ip6_address IS NOT NULL OR ip_address = '' OR ip6_address = '');
+ALTER TABLE server ADD CONSTRAINT need_gateway_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_gateway IS NOT NULL);
+ALTER TABLE server ADD CONSTRAINT need_netmask_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_netmask IS NOT NULL);
+
+UPDATE server SET ip_address = host(ip_address.address),
+ ip_netmask = host(netmask(ip_address.address)),
+ ip_gateway = host(ip_address.gateway),
Review comment:
Same result when running `goose -env production down`:
```sql
2020/07/09 21:13:36 FAIL 20200607000000_remove_redundancy.sql (pq: CASE types inet and text cannot be matched), quitting migration.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4730: Database migration 2 for multiple interfaces
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4730:
URL: https://github.com/apache/trafficcontrol/pull/4730#discussion_r461978948
##########
File path: traffic_ops/app/db/migrations/2020072700000000_remove_redundancy.sql
##########
@@ -0,0 +1,70 @@
+/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+-- +goose Up
+ALTER TABLE server DROP CONSTRAINT need_at_least_one_ip;
+ALTER TABLE server DROP CONSTRAINT need_gateway_if_ip;
+ALTER TABLE server DROP CONSTRAINT need_netmask_if_ip;
+
+ALTER TABLE server DROP COLUMN interface_name;
+ALTER TABLE server DROP COLUMN ip_address;
+ALTER TABLE server DROP COLUMN ip_netmask;
+ALTER TABLE server DROP COLUMN ip_gateway;
+ALTER TABLE server DROP COLUMN ip6_address;
+ALTER TABLE server DROP COLUMN ip6_gateway;
+ALTER TABLE server DROP COLUMN interface_mtu;
+ALTER TABLE server DROP COLUMN ip_address_is_service;
+ALTER TABLE server DROP COLUMN ip6_address_is_service;
+
+
+-- +goose Down
+ALTER TABLE server ADD COLUMN interface_name text DEFAULT '' NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_netmask text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN interface_mtu bigint DEFAULT '9000'::bigint NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address_is_service boolean DEFAULT true;
+ALTER TABLE server ADD COLUMN ip6_address_is_service boolean DEFAULT true;
+
+ALTER TABLE server ADD CONSTRAINT need_at_least_one_ip CHECK (ip_address IS NOT NULL OR ip6_address IS NOT NULL OR ip_address = '' OR ip6_address = '');
+ALTER TABLE server ADD CONSTRAINT need_gateway_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_gateway IS NOT NULL);
+ALTER TABLE server ADD CONSTRAINT need_netmask_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_netmask IS NOT NULL);
+
+UPDATE server SET ip_address = host(ip_address.address),
+ ip_netmask = host(netmask(ip_address.address)),
+ ip_gateway = host(ip_address.gateway),
+ ip_address_is_service = ip_address.service_address,
+ interface_name = ip_address.interface,
+ interface_mtu = interface.mtu
+ FROM ip_address
+ JOIN interface ON ip_address.interface = interface.name
+ WHERE server.id = ip_address.server
+ AND family(ip_address.address) = 4
+ AND ip_address.service_address;
+
+UPDATE server SET ip6_address = CASE
+ WHEN masklen(ip_address.address) = 128 then ip_address.address
+ ELSE ip_address.address
+ END,
Review comment:
Since `ip_address.address` is the result used in either case, can the `CASE` expression be removed?
##########
File path: traffic_ops/app/db/migrations/2020072700000000_remove_redundancy.sql
##########
@@ -0,0 +1,70 @@
+/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+-- +goose Up
+ALTER TABLE server DROP CONSTRAINT need_at_least_one_ip;
+ALTER TABLE server DROP CONSTRAINT need_gateway_if_ip;
+ALTER TABLE server DROP CONSTRAINT need_netmask_if_ip;
+
+ALTER TABLE server DROP COLUMN interface_name;
+ALTER TABLE server DROP COLUMN ip_address;
+ALTER TABLE server DROP COLUMN ip_netmask;
+ALTER TABLE server DROP COLUMN ip_gateway;
+ALTER TABLE server DROP COLUMN ip6_address;
+ALTER TABLE server DROP COLUMN ip6_gateway;
+ALTER TABLE server DROP COLUMN interface_mtu;
+ALTER TABLE server DROP COLUMN ip_address_is_service;
+ALTER TABLE server DROP COLUMN ip6_address_is_service;
+
+
+-- +goose Down
+ALTER TABLE server ADD COLUMN interface_name text DEFAULT '' NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_netmask text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN interface_mtu bigint DEFAULT '9000'::bigint NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address_is_service boolean DEFAULT true;
+ALTER TABLE server ADD COLUMN ip6_address_is_service boolean DEFAULT true;
+
+ALTER TABLE server ADD CONSTRAINT need_at_least_one_ip CHECK (ip_address IS NOT NULL OR ip6_address IS NOT NULL OR ip_address = '' OR ip6_address = '');
+ALTER TABLE server ADD CONSTRAINT need_gateway_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_gateway IS NOT NULL);
+ALTER TABLE server ADD CONSTRAINT need_netmask_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_netmask IS NOT NULL);
+
+UPDATE server SET ip_address = host(ip_address.address),
+ ip_netmask = host(netmask(ip_address.address)),
+ ip_gateway = host(ip_address.gateway),
+ ip_address_is_service = ip_address.service_address,
+ interface_name = ip_address.interface,
+ interface_mtu = interface.mtu
+ FROM ip_address
+ JOIN interface ON ip_address.interface = interface.name
+ WHERE server.id = ip_address.server
+ AND family(ip_address.address) = 4
+ AND ip_address.service_address;
+
+UPDATE server SET ip6_address = CASE
+ WHEN masklen(ip_address.address) = 128 then ip_address.address
+ ELSE ip_address.address
+ END,
+ ip6_gateway = CASE
+ WHEN masklen(ip_address.gateway) = 128 then ip_address.gateway
+ ELSE ip_address.gateway
+ END,
Review comment:
Same question here: Since `ip_address.gateway` is the result used in either case, can the `CASE` expression be removed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] ocket8888 merged pull request #4730: Database migration 2 for multiple interfaces
Posted by GitBox <gi...@apache.org>.
ocket8888 merged pull request #4730:
URL: https://github.com/apache/trafficcontrol/pull/4730
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mattjackson220 commented on a change in pull request #4730: Database migration 2 for multiple interfaces
Posted by GitBox <gi...@apache.org>.
mattjackson220 commented on a change in pull request #4730:
URL: https://github.com/apache/trafficcontrol/pull/4730#discussion_r462295202
##########
File path: traffic_ops/app/db/migrations/2020072700000000_remove_redundancy.sql
##########
@@ -0,0 +1,70 @@
+/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+-- +goose Up
+ALTER TABLE server DROP CONSTRAINT need_at_least_one_ip;
+ALTER TABLE server DROP CONSTRAINT need_gateway_if_ip;
+ALTER TABLE server DROP CONSTRAINT need_netmask_if_ip;
+
+ALTER TABLE server DROP COLUMN interface_name;
+ALTER TABLE server DROP COLUMN ip_address;
+ALTER TABLE server DROP COLUMN ip_netmask;
+ALTER TABLE server DROP COLUMN ip_gateway;
+ALTER TABLE server DROP COLUMN ip6_address;
+ALTER TABLE server DROP COLUMN ip6_gateway;
+ALTER TABLE server DROP COLUMN interface_mtu;
+ALTER TABLE server DROP COLUMN ip_address_is_service;
+ALTER TABLE server DROP COLUMN ip6_address_is_service;
+
+
+-- +goose Down
+ALTER TABLE server ADD COLUMN interface_name text DEFAULT '' NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_netmask text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN interface_mtu bigint DEFAULT '9000'::bigint NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address_is_service boolean DEFAULT true;
+ALTER TABLE server ADD COLUMN ip6_address_is_service boolean DEFAULT true;
+
+ALTER TABLE server ADD CONSTRAINT need_at_least_one_ip CHECK (ip_address IS NOT NULL OR ip6_address IS NOT NULL OR ip_address = '' OR ip6_address = '');
+ALTER TABLE server ADD CONSTRAINT need_gateway_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_gateway IS NOT NULL);
+ALTER TABLE server ADD CONSTRAINT need_netmask_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_netmask IS NOT NULL);
+
+UPDATE server SET ip_address = host(ip_address.address),
+ ip_netmask = host(netmask(ip_address.address)),
+ ip_gateway = host(ip_address.gateway),
+ ip_address_is_service = ip_address.service_address,
+ interface_name = ip_address.interface,
+ interface_mtu = interface.mtu
+ FROM ip_address
+ JOIN interface ON ip_address.interface = interface.name
+ WHERE server.id = ip_address.server
+ AND family(ip_address.address) = 4
+ AND ip_address.service_address;
+
+UPDATE server SET ip6_address = CASE
+ WHEN masklen(ip_address.address) = 128 then ip_address.address
+ ELSE ip_address.address
+ END,
Review comment:
oh yea definitely. i dont remember why i thought i needed the `host(ip_address.address)` before but without it theres no need for the `CASE`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] zrhoffman commented on a change in pull request #4730: Database migration 2 for multiple interfaces
Posted by GitBox <gi...@apache.org>.
zrhoffman commented on a change in pull request #4730:
URL: https://github.com/apache/trafficcontrol/pull/4730#discussion_r452356835
##########
File path: traffic_ops/app/db/migrations/20200607000000_remove_redundancy.sql
##########
@@ -0,0 +1,70 @@
+/*
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+*/
+
+-- +goose Up
+ALTER TABLE server DROP CONSTRAINT need_at_least_one_ip;
+ALTER TABLE server DROP CONSTRAINT need_gateway_if_ip;
+ALTER TABLE server DROP CONSTRAINT need_netmask_if_ip;
+
+ALTER TABLE server DROP COLUMN interface_name;
+ALTER TABLE server DROP COLUMN ip_address;
+ALTER TABLE server DROP COLUMN ip_netmask;
+ALTER TABLE server DROP COLUMN ip_gateway;
+ALTER TABLE server DROP COLUMN ip6_address;
+ALTER TABLE server DROP COLUMN ip6_gateway;
+ALTER TABLE server DROP COLUMN interface_mtu;
+ALTER TABLE server DROP COLUMN ip_address_is_service;
+ALTER TABLE server DROP COLUMN ip6_address_is_service;
+
+
+-- +goose Down
+ALTER TABLE server ADD COLUMN interface_name text DEFAULT '' NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_netmask text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_address text DEFAULT '';
+ALTER TABLE server ADD COLUMN ip6_gateway text DEFAULT '';
+ALTER TABLE server ADD COLUMN interface_mtu bigint DEFAULT '9000'::bigint NOT NULL;
+ALTER TABLE server ADD COLUMN ip_address_is_service boolean DEFAULT true;
+ALTER TABLE server ADD COLUMN ip6_address_is_service boolean DEFAULT true;
+
+ALTER TABLE server ADD CONSTRAINT need_at_least_one_ip CHECK (ip_address IS NOT NULL OR ip6_address IS NOT NULL OR ip_address = '' OR ip6_address = '');
+ALTER TABLE server ADD CONSTRAINT need_gateway_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_gateway IS NOT NULL);
+ALTER TABLE server ADD CONSTRAINT need_netmask_if_ip CHECK (ip_address IS NULL OR ip_address = '' OR ip_netmask IS NOT NULL);
+
+UPDATE server SET ip_address = host(ip_address.address),
+ ip_netmask = host(netmask(ip_address.address)),
+ ip_gateway = host(ip_address.gateway),
Review comment:
Getting SQL error:
```sql
SQL Error [42804]: ERROR: CASE types inet and text cannot be matched
Position: 92
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org