[GitHub] [arrow] jorisvandenbossche commented on a diff in pull request #12530: ARROW-14612: [C++] Support for filename-based partitioning

[GitBox <gi...@apache.org>]

jorisvandenbossche commented on code in PR #12530:
URL: https://github.com/apache/arrow/pull/12530#discussion_r841760449


##########
python/pyarrow/tests/test_dataset.py:
##########
@@ -569,6 +570,22 @@ def test_partitioning():
         with pytest.raises(pa.ArrowInvalid):
             partitioning.parse(shouldfail)
 
+    partitioning = ds.FilenamePartitioning(
+        pa.schema([
+            pa.field('group', pa.int64()),
+            pa.field('key', pa.float64())
+        ])
+    )
+    assert partitioning.dictionaries is None

Review Comment:
   @sanjibansg is there a specific reason you changed this to return an empty list instead of None? 
   
   I am not necessarily saying that the original API to return None was better, but it _is_ a change in behaviour that we should be a bit conscious about since there might already be people relying on this (and so only do this if there is a good reason for it). 
   
   You mentioned
   
   >  the dictionaries() method might have an issue where it returned None object even if the Partitioning object has a dictionary field.
   
   but I don't directly see any additional case in the tests related to this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org