You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "wuxihao01 (via GitHub)" <gi...@apache.org> on 2023/04/22 10:28:45 UTC
[GitHub] [shardingsphere] wuxihao01 opened a new pull request, #25274: commit log
wuxihao01 opened a new pull request, #25274:
URL: https://github.com/apache/shardingsphere/pull/25274
Fixes #25190 .
Changes proposed in this pull request:
-
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wuxihao01 commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "wuxihao01 (via GitHub)" <gi...@apache.org>.
wuxihao01 commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1519380614
> ${maven.projectBasedir}
I try to use `${maven.projectBasedir}` to replace and build failed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1519365230
> > * `${maven.multiModuleProjectDirectory}` is an internal variable defined by `./mvnw`, why not use `${user.dir}`? 🤔
>
> I try to use ${user.dir} to replace ${maven.multiModuleProjectDirectory} and find that if working dir is not root of ShardingSphere，the ${user.dir} could not find the src/resources/spotless/java.xml either.
- What about `${project.basedir}`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wuxihao01 commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "wuxihao01 (via GitHub)" <gi...@apache.org>.
wuxihao01 commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1519325378
> * `${maven.multiModuleProjectDirectory}` is an internal variable defined by `./mvnw`, why not use `${user.dir}`? 🤔
I try to use ${user.dir} to replace ${maven.multiModuleProjectDirectory} and find that if working dir is not root of ShardingSphere，the ${user.dir} could not find the src/resources/spotless/java.xml either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1518924545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1518678530
> The GitHub actions are all passed before the PR merge, is it necessary to merge it?
https://github.com/apache/shardingsphere/pull/24927 caused Maven build failure if working dir is not root of ShardingSphere.
Just try `cd` into some modules and execute `mvn install` and you will get it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1519316200
> * `${maven.multiModuleProjectDirectory}` is an internal variable defined by `./mvnw`, why not use `${user.dir}`? 🤔
We need the content root of ShardingSphere project, I don't think `user.dir` is what we need.
But, maybe we could try `${maven.projectBasedir}`. https://maven.apache.org/docs/3.3.1/release-notes.html#jvm-and-command-line-options
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wuxihao01 commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "wuxihao01 (via GitHub)" <gi...@apache.org>.
wuxihao01 commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1519379880
> * ${project.basedir}
I try in Windows for` ${project.basedir}` but build failed either. I think it could work in Linux
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wuxihao01 commented on pull request #25274: commit log
Posted by "wuxihao01 (via GitHub)" <gi...@apache.org>.
wuxihao01 commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1518628203
> Please clarify the PR title and commit log.
Sorry, This is my first attempt to resolve the issue. Do I need to roll back again and write a log in the local commit before uploading and submitting again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] linghengqian commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1519319636
> > * `${maven.multiModuleProjectDirectory}` is an internal variable defined by `./mvnw`, why not use `${user.dir}`? 🤔
>
> We need the content root of ShardingSphere project, I don't think `user.dir` is what we need.
>
> But, maybe we could try `${maven.projectBasedir}`. https://maven.apache.org/docs/3.3.1/release-notes.html#jvm-and-command-line-options
- `${project.basedir}` is a good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] wuxihao01 commented on pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "wuxihao01 (via GitHub)" <gi...@apache.org>.
wuxihao01 commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1518662583
> The GitHub actions are all passed before the PR merge, is it necessary to merge it?
Sorry,I am a first-time contributor，I change the pom.xml to fix the problem(#25190 ) and commit log in the latest commit. Do I need to do anything else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #25274: Build failed with error Could not find resource 'src/resources/spotless/java.xml' if working dir is not root of ShardingSphere
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu merged PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] TeslaCN commented on pull request #25274: commit log
Posted by "TeslaCN (via GitHub)" <gi...@apache.org>.
TeslaCN commented on PR #25274:
URL: https://github.com/apache/shardingsphere/pull/25274#issuecomment-1518622470
Please clarify the PR title and commit log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org