Re: Review Request 58072: Added resource support for new offer operations.

[Qian Zhang <zh...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58072/#review175345
-----------------------------------------------------------




src/common/resources.cpp
Lines 1463-1464 (patched)
<https://reviews.apache.org/r/58072/#comment248797>

    We may need to validate `source` is a RAW disk resource.



src/common/resources.cpp
Lines 1466-1467 (patched)
<https://reviews.apache.org/r/58072/#comment248798>

    We may need to validate `target_type` is either `MOUNT` or `PATH` but not others.


- Qian Zhang


On April 5, 2017, 5:26 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58072/
> -----------------------------------------------------------
> 
> (Updated April 5, 2017, 5:26 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Jie Yu.
> 
> 
> Bugs: MESOS-7314
>     https://issues.apache.org/jira/browse/MESOS-7314
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When applying offer operations to resources, one has to account for
> changing resources depending on the operation. For resource-related
> operations, disk resources will be converted from a type to another.
> So, by applying such an operation, we will substract the resource
> of the source type and add the resource of the target type of that
> operation.
> 
> 
> Diffs
> -----
> 
>   src/common/resources.cpp c26e0f995006dc6b2e70a491cea58fa90347e42a 
>   src/tests/resources_tests.cpp 343cab2af225a05e32c5a8bd4a5d9ddfbf76536d 
>   src/v1/resources.cpp a53deafbea399a1bcf729d1c151bc46e9da04e11 
> 
> 
> Diff: https://reviews.apache.org/r/58072/diff/7/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>