You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/04/05 19:45:06 UTC

Review Request: Updated status update manager tests to use new testing abstractions.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10309/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Description
-------

This also eliminates the sleep! ;)


Diffs
-----

  src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e 

Diff: https://reviews.apache.org/r/10309/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter=StatusUpdateManagerTest.* --gtest_repeat=1000 --gtest_shuffle


Thanks,

Benjamin Hindman

Re: Review Request: Updated status update manager tests to use new testing abstractions.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10309/#review18769
-----------------------------------------------------------

Ship it!


Ship It!

- Vinod Kone


On April 5, 2013, 5:48 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10309/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 5:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> This also eliminates the sleep! ;)
> 
> 
> Diffs
> -----
> 
>   src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e 
> 
> Diff: https://reviews.apache.org/r/10309/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter=StatusUpdateManagerTest.* --gtest_repeat=1000 --gtest_shuffle
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Updated status update manager tests to use new testing abstractions.

Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10309/#review18768
-----------------------------------------------------------



src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10309/#comment39184>

    At some point we should move this up into MesosClusterTest fixture.



src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10309/#comment39182>

    because we expect it to be None() at the end of the file.



src/tests/status_update_manager_tests.cpp
<https://reviews.apache.org/r/10309/#comment39183>

    thank you


- Vinod Kone


On April 5, 2013, 5:48 p.m., Benjamin Hindman wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10309/
> -----------------------------------------------------------
> 
> (Updated April 5, 2013, 5:48 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Description
> -------
> 
> This also eliminates the sleep! ;)
> 
> 
> Diffs
> -----
> 
>   src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e 
> 
> Diff: https://reviews.apache.org/r/10309/diff/
> 
> 
> Testing
> -------
> 
> ./bin/mesos-tests.sh --gtest_filter=StatusUpdateManagerTest.* --gtest_repeat=1000 --gtest_shuffle
> 
> 
> Thanks,
> 
> Benjamin Hindman
> 
>

Re: Review Request: Updated status update manager tests to use new testing abstractions.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10309/
-----------------------------------------------------------

(Updated April 5, 2013, 5:48 p.m.)


Review request for mesos and Vinod Kone.


Changes
-------

Made sure the test uses the copied flags not cluster flags.


Description
-------

This also eliminates the sleep! ;)


Diffs (updated)
-----

  src/tests/status_update_manager_tests.cpp a355ecd09a0462e701707862ceb62584826a4e5e 

Diff: https://reviews.apache.org/r/10309/diff/


Testing
-------

./bin/mesos-tests.sh --gtest_filter=StatusUpdateManagerTest.* --gtest_repeat=1000 --gtest_shuffle


Thanks,

Benjamin Hindman