You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2015/07/22 20:16:01 UTC
Review Request 36698: Updated scheduler library to send REQUEST call.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36698/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-3089
https://issues.apache.org/jira/browse/MESOS-3089
Repository: mesos
Description
-------
Doesn't update the scheduler driver yet, only the library.
Diffs
-----
include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886
include/mesos/scheduler/scheduler.proto e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6
src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0
src/scheduler/scheduler.cpp ac2358594de3861a1dddcdf82c2cba670c6f7181
src/tests/scheduler_tests.cpp 13fecb2b42dd440951f3da3f76e918c976ac1570
Diff: https://reviews.apache.org/r/36698/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36698: Updated scheduler library to send REQUEST
call.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36698/#review92631
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36698]
All tests passed.
- Mesos ReviewBot
On July 22, 2015, 6:16 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36698/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3089
> https://issues.apache.org/jira/browse/MESOS-3089
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doesn't update the scheduler driver yet, only the library.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886
> include/mesos/scheduler/scheduler.proto e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6
> src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
> src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0
> src/scheduler/scheduler.cpp ac2358594de3861a1dddcdf82c2cba670c6f7181
> src/tests/scheduler_tests.cpp 13fecb2b42dd440951f3da3f76e918c976ac1570
>
> Diff: https://reviews.apache.org/r/36698/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 36698: Updated scheduler library to send REQUEST
call.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36698/
-----------------------------------------------------------
(Updated July 23, 2015, 12:21 a.m.)
Review request for mesos and Ben Mahler.
Changes
-------
removed extra line. NNFR.
Bugs: MESOS-3089
https://issues.apache.org/jira/browse/MESOS-3089
Repository: mesos
Description
-------
Doesn't update the scheduler driver yet, only the library.
Diffs (updated)
-----
include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886
include/mesos/scheduler/scheduler.proto e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6
src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0
src/scheduler/scheduler.cpp ac2358594de3861a1dddcdf82c2cba670c6f7181
src/tests/scheduler_tests.cpp 13fecb2b42dd440951f3da3f76e918c976ac1570
Diff: https://reviews.apache.org/r/36698/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 36698: Updated scheduler library to send REQUEST
call.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36698/#review92667
-----------------------------------------------------------
Ship it!
include/mesos/mesos.proto (line 784)
<https://reviews.apache.org/r/36698/#comment146891>
Remove this line as well?
- Ben Mahler
On July 22, 2015, 6:16 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36698/
> -----------------------------------------------------------
>
> (Updated July 22, 2015, 6:16 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-3089
> https://issues.apache.org/jira/browse/MESOS-3089
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Doesn't update the scheduler driver yet, only the library.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto bcb38d934c7f223b9a23746b273e581e0e8da886
> include/mesos/scheduler/scheduler.proto e2ca8e5cfb3d6405bf7be93d621743ce48c6c7e6
> src/master/master.hpp 2343a684402972a8c336c0dcdde0bfaffabe7cec
> src/master/master.cpp 2f00f240ed2cd59ec0c2eae7fd2567f0edb8d9e0
> src/scheduler/scheduler.cpp ac2358594de3861a1dddcdf82c2cba670c6f7181
> src/tests/scheduler_tests.cpp 13fecb2b42dd440951f3da3f76e918c976ac1570
>
> Diff: https://reviews.apache.org/r/36698/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>