You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wicket.apache.org by Igor Vaynberg <ig...@gmail.com> on 2009/03/02 21:25:29 UTC

Re: RequestLogger change - include Page Parameters for BookmarkablePages

create a jira issue please

-igor

On Mon, Mar 2, 2009 at 12:23 PM, Alex Parvulescu
<al...@gmail.com> wrote:
> Hello,
>
> Can you please add page parameters to the IRequestTarget logging ?
>
> Its a simple addition to
> org.apache.wicket.protocol.http.RequestLogger#getRequestTargetString(IRequestTarget
> target) :
>
> so this
>
>        else if (target instanceof IBookmarkablePageRequestTarget)
>        {
>            IBookmarkablePageRequestTarget pageRequestTarget =
> (IBookmarkablePageRequestTarget)target;
>            sb.append("BookmarkablePage[");
>            sb.append(pageRequestTarget.getPageClass().getName());
>            sb.append("]");
>
>
> becomes
>
>        } else if (target instanceof IBookmarkablePageRequestTarget) {
>            IBookmarkablePageRequestTarget pageRequestTarget =
> (IBookmarkablePageRequestTarget) target;
>            sb.append("BookmarkablePage[");
>            sb.append(pageRequestTarget.getPageClass().getName());
>            sb.append("(");
>            sb.append(pageRequestTarget.getPageParameters());
>            sb.append(")]");
>
> and my life is beautiful again.
>
> All jokes aside , i think the page params should be there for logging
> purposes.
>
> Thanks,
> Alex
>

Re: RequestLogger change - include Page Parameters for BookmarkablePages

Posted by Alex Parvulescu <al...@gmail.com>.
done,
https://issues.apache.org/jira/browse/WICKET-2139

thanks igor
-- 
View this message in context: http://www.nabble.com/RequestLogger-change---include-Page-Parameters-for-BookmarkablePages-tp22295982p22305001.html
Sent from the Wicket - Dev mailing list archive at Nabble.com.