[GitHub] [ignite] xtern commented on a diff in pull request #10189: IGNITE-17502 Tasks to sent the snapshot files are not ordered

[GitBox <gi...@apache.org>]

xtern commented on code in PR #10189:
URL: https://github.com/apache/ignite/pull/10189#discussion_r944210268


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/snapshot/SnapshotFilesRequestMessage.java:
##########
@@ -91,9 +92,10 @@ public Map<Integer, Set<Integer>> parts() {
         Map<Integer, Set<Integer>> res = new HashMap<>();
 
         for (Map.Entry<Integer, int[]> e : parts.entrySet()) {
-            res.put(e.getKey(), e.getValue().length == 0 ? null : Arrays.stream(e.getValue())
-                .boxed()
-                .collect(Collectors.toSet()));
+            if (F.isEmpty(e.getValue()))

Review Comment:
   Why can't we them filter in the constructor?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org