You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by SteveKing <st...@gmx.ch> on 2003/10/18 16:53:47 UTC
svn blame should call the cancel callback more often
Hi,
While trying out the new svn blame command (thanks for that btw!)
I noticed that it can't be cancelled - the cancel callback is only
called when the log is fetched, but that's it. Later in the time consuming
diff task the callback is not called anymore and so the user
can't really cancel the operation.
Is it possible to call the cancel callback in that for() loop (line 389 in
blame.c)
once for every loop? Or would that break something?
Just as a sidenote: it would even be better if in that for() loop another
callback
would be called to tell the client(s) which revision is currently worked on,
maybe
even together with the total amount of revision. That would give the clients
a
chance to show some progress information...
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn blame should call the cancel callback more often
Posted by mark benedetto king <mb...@lowlatency.com>.
On Sat, Oct 18, 2003 at 06:53:47PM +0200, SteveKing wrote:
>
> Just as a sidenote: it would even be better if in that for() loop another
> callback
> would be called to tell the client(s) which revision is currently worked on,
> maybe
> even together with the total amount of revision. That would give the clients
> a
> chance to show some progress information...
>
svn_wc_notify_blame_revision added in r8127.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn blame should call the cancel callback more often
Posted by mark benedetto king <mb...@lowlatency.com>.
On Sat, Oct 18, 2003 at 06:53:47PM +0200, SteveKing wrote:
>
> Is it possible to call the cancel callback in that for() loop (line 389 in
> blame.c)
> once for every loop? Or would that break something?
>
It would have. Temporary files would have been leaked. But the feature
(with the fix for the temporary files) was added in r8129.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn blame should call the cancel callback more often
Posted by mark benedetto king <mb...@lowlatency.com>.
On Sat, Oct 18, 2003 at 06:53:47PM +0200, SteveKing wrote:
> Hi,
>
> While trying out the new svn blame command (thanks for that btw!)
> I noticed that it can't be cancelled - the cancel callback is only
> called when the log is fetched, but that's it. Later in the time consuming
> diff task the callback is not called anymore and so the user
> can't really cancel the operation.
Before r7438, the cancel callback was called between each fulltext
retrieval. I realized earlier today that the restructuring done in
r7438 lost that feature. I'll put it back in.
> Just as a sidenote: it would even be better if in that for() loop another
> callback
> would be called to tell the client(s) which revision is currently worked on,
> maybe
> even together with the total amount of revision. That would give the clients
> a
> chance to show some progress information...
That's a great suggestion. I'll look into it.
--ben
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org