You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Tomislav Stojcevich (JIRA)" <ji...@codehaus.org> on 2005/11/02 22:59:06 UTC

[jira] Created: (MNG-1402) application.xml generated incorrectly

application.xml generated incorrectly
-------------------------------------

         Key: MNG-1402
         URL: http://jira.codehaus.org/browse/MNG-1402
     Project: Maven 2
        Type: Bug
  Components: maven-ear-plugin  
    Versions: 2.0    
    Reporter: Tomislav Stojcevich
    Priority: Minor


When generating an application.xml the description is written out before the display-name.

According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd

A work around is to not use a description element in the pom.



-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1402) application.xml generated incorrectly

Posted by "Tomislav Stojcevich (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1402?page=comments#action_49921 ] 

Tomislav Stojcevich commented on MNG-1402:
------------------------------------------

It does look like they switchd the order.

http://java.sun.com/dtd/application_1_3.dtd shows:
  <!ELEMENT application (icon?, display-name, description?, module+,
		security-role*)>


http://java.sun.com/xml/ns/j2ee/j2ee_1_4.xsd which is included in http://java.sun.com/xml/ns/j2ee/application_1_4.xsd shows
  <xsd:sequence>
    <xsd:element name="description" type="j2ee:descriptionType" minOccurs="0" maxOccurs="unbounded"/>
    <xsd:element name="display-name" type="j2ee:display-nameType" minOccurs="0" maxOccurs="unbounded"/>
    <xsd:element name="icon" type="j2ee:iconType" minOccurs="0" maxOccurs="unbounded"/>
  </xsd:sequence>

Attached is the new patch that checks for the version and writes them out appropriately.
I generated both and both validated correctly.

> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MNG-1402
>          URL: http://jira.codehaus.org/browse/MNG-1402
>      Project: Maven 2
>         Type: Bug
>   Components: maven-ear-plugin
>     Versions: 2.0
>     Reporter: Tomislav Stojcevich
>     Priority: Minor
>  Attachments: MNG-1402-maven-ear-plugin.patch, MNG-1402-maven-ear-pluginB.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1402) application.xml generated incorrectly

Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1402?page=comments#action_49849 ] 

Brett Porter commented on MNG-1402:
-----------------------------------

this is the revers to my fix here:

http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/maven-ear-plugin/src/main/java/org/apache/maven/plugin/ear/ApplicationXmlWriter.java?rev=292709&r1=291287&r2=292709&diff_format=h

is it possible that the order is different in 1.3 and 1.4? I remember needing this for OpenEJB to build.


> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MNG-1402
>          URL: http://jira.codehaus.org/browse/MNG-1402
>      Project: Maven 2
>         Type: Bug
>   Components: maven-ear-plugin
>     Versions: 2.0
>     Reporter: Tomislav Stojcevich
>     Priority: Minor
>  Attachments: MNG-1402-maven-ear-plugin.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MNG-1402) application.xml generated incorrectly

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1402?page=all ]
     
Stephane Nicoll closed MNG-1402:
--------------------------------

     Resolution: Fixed
    Fix Version: 2.0.1

Applied, thanks.

> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MNG-1402
>          URL: http://jira.codehaus.org/browse/MNG-1402
>      Project: Maven 2
>         Type: Bug
>   Components: maven-ear-plugin
>     Versions: 2.0
>     Reporter: Tomislav Stojcevich
>     Assignee: Stephane Nicoll
>     Priority: Minor
>      Fix For: 2.0.1
>  Attachments: MNG-1402-maven-ear-plugin.patch, MNG-1402-maven-ear-pluginB.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Reopened: (MEAR-5) application.xml generated incorrectly

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MEAR-5?page=all ]
     
Stephane Nicoll reopened MEAR-5:
--------------------------------


> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MEAR-5
>          URL: http://jira.codehaus.org/browse/MEAR-5
>      Project: Maven 2.x Ear Plugin
>         Type: Bug

>     Reporter: Tomislav Stojcevich
>     Assignee: Stephane Nicoll
>     Priority: Minor
>      Fix For: 2.1
>  Attachments: MNG-1402-maven-ear-plugin.patch, MNG-1402-maven-ear-pluginB.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Commented: (MNG-1402) application.xml generated incorrectly

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
    [ http://jira.codehaus.org/browse/MNG-1402?page=comments#action_50045 ] 

Stephane Nicoll commented on MNG-1402:
--------------------------------------

We will need to fix this in M2 as well. I'll take care of that.

> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MNG-1402
>          URL: http://jira.codehaus.org/browse/MNG-1402
>      Project: Maven 2
>         Type: Bug
>   Components: maven-ear-plugin
>     Versions: 2.0
>     Reporter: Tomislav Stojcevich
>     Assignee: Stephane Nicoll
>     Priority: Minor
>  Attachments: MNG-1402-maven-ear-plugin.patch, MNG-1402-maven-ear-pluginB.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1402) application.xml generated incorrectly

Posted by "Tomislav Stojcevich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1402?page=all ]

Tomislav Stojcevich updated MNG-1402:
-------------------------------------

    Attachment: MNG-1402-maven-ear-pluginB.patch

> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MNG-1402
>          URL: http://jira.codehaus.org/browse/MNG-1402
>      Project: Maven 2
>         Type: Bug
>   Components: maven-ear-plugin
>     Versions: 2.0
>     Reporter: Tomislav Stojcevich
>     Priority: Minor
>  Attachments: MNG-1402-maven-ear-plugin.patch, MNG-1402-maven-ear-pluginB.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Closed: (MEAR-5) application.xml generated incorrectly

Posted by "Stephane Nicoll (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MEAR-5?page=all ]
     
Stephane Nicoll closed MEAR-5:
------------------------------

     Resolution: Fixed
    Fix Version: 2.1

> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MEAR-5
>          URL: http://jira.codehaus.org/browse/MEAR-5
>      Project: Maven 2.x Ear Plugin
>         Type: Bug

>     Reporter: Tomislav Stojcevich
>     Assignee: Stephane Nicoll
>     Priority: Minor
>      Fix For: 2.1
>  Attachments: MNG-1402-maven-ear-plugin.patch, MNG-1402-maven-ear-pluginB.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


[jira] Updated: (MNG-1402) application.xml generated incorrectly

Posted by "Tomislav Stojcevich (JIRA)" <ji...@codehaus.org>.
     [ http://jira.codehaus.org/browse/MNG-1402?page=all ]

Tomislav Stojcevich updated MNG-1402:
-------------------------------------

    Attachment: MNG-1402-maven-ear-plugin.patch

Attached is the patch file.

> application.xml generated incorrectly
> -------------------------------------
>
>          Key: MNG-1402
>          URL: http://jira.codehaus.org/browse/MNG-1402
>      Project: Maven 2
>         Type: Bug
>   Components: maven-ear-plugin
>     Versions: 2.0
>     Reporter: Tomislav Stojcevich
>     Priority: Minor
>  Attachments: MNG-1402-maven-ear-plugin.patch
>
>
> When generating an application.xml the description is written out before the display-name.
> According to the DTD, display-name needs to be first.  See:  http://java.sun.com/dtd/application_1_3.dtd
> A work around is to not use a description element in the pom.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org