You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/10/03 22:09:46 UTC
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
John Russell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8200
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
IMPALA-4623: [DOCS] Document file handle caching
Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_known_issues.xml
M docs/topics/impala_scalability.xml
3 files changed, 89 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/8200/1
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Mostafa Mokhtar, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8200
to look at the new patch set (#3).
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
IMPALA-4623: [DOCS] Document file handle caching
Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_known_issues.xml
M docs/topics/impala_scalability.xml
3 files changed, 92 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/8200/3
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 3:
No, you're the voice of authority on this one, please +2 if happy.
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 23:31:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@967
PS1, Line 967: although the encryption layer
: adds overhead that might lessen the benefit of the caching.
> The closest thing I can think of as being related to this is IMPALA-5909, w
OK, sentence removed.
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:51:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Joe McDonnell, Mostafa Mokhtar, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8200
to look at the new patch set (#2).
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
IMPALA-4623: [DOCS] Document file handle caching
Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_known_issues.xml
M docs/topics/impala_scalability.xml
3 files changed, 94 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/00/8200/2
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 23:38:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@967
PS1, Line 967: although the encryption layer
: adds overhead that might lessen the benefit of the caching.
> I'm not familiar with this overhead. What is this referring to?
I had written in the notes from our conversation HDFS encryption adds overhead". From when we were thinking about all the other complicating factors, like Sentry GRANT/REVOKE.
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@973
PS1, Line 973: 20 thousand
> Just curious: How do you decide to use "20 thousand" vs "20,000"?
For big numbers, I try to stick with either spelled-out forms or obvious powers of 2. (Like I would say 65536 with no comma.) There are so many other separator conventions internationally (https://docs.oracle.com/cd/E19455-01/806-0169/overview-9/index.html) I don't want to be too US-centric.
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@991
PS1, Line 991: evict any stale file handles from the cache
> The file handles won't actually be evicted directly. The new metadata will
Done
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@995
PS1, Line 995: To evaluate the effectiveness of file handle caching for a particular workload, issue the
: <codeph>PROFILE</codeph> statement in <cmdname>impala-shell</cmdname> or examine query
: profiles in the Impala web UI. Look for the ratio of <codeph>CachedFileHandlesHitCount</codeph>
: (ideally, should be high) to <codeph>CachedFileHandlesMissCount</codeph> (ideally, should be low).
: Before starting any evaluation, run some representative queries to <q>warm up</q> the cache,
: because the first time each data file is accessed is always recorded as a cache miss.
> I'm not sure this belongs here, but information about the cache across the
Let's be inclusive for this first iteration and then fine-tune later if needed. We tend to be skimpy with such information which is a weakness IMO.
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 20:48:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@967
PS1, Line 967: although the encryption layer
: adds overhead that might lessen the benefit of the caching.
> I had written in the notes from our conversation HDFS encryption adds overh
The closest thing I can think of as being related to this is IMPALA-5909, where a problem with HDFS code causes excessive logging. However, I don't think that matches this statement, and it is a bug.
If the sole source for this is me, then I don't think it should be included. I don't remember what I said originally (and it may have been ambiguous), but I don't currently think this statement is true.
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 2
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 22:44:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_known_issues.xml@338
PS1, Line 338: continuously appended by an HDFS mechanism
This also applies if an HDFS file is overwritten in place.
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml
File docs/topics/impala_scalability.xml:
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@967
PS1, Line 967: although the encryption layer
: adds overhead that might lessen the benefit of the caching.
I'm not familiar with this overhead. What is this referring to?
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@973
PS1, Line 973: 20 thousand
Just curious: How do you decide to use "20 thousand" vs "20,000"?
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@991
PS1, Line 991: evict any stale file handles from the cache
The file handles won't actually be evicted directly. The new metadata will mean that new statements will no longer use that file handle and eventually it will get aged out. I'm not sure if this distinction is important for documentation, but I think the important thing is that the memory may not be freed immediately. (This is something we are likely to change in a future release.)
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_scalability.xml@995
PS1, Line 995: To evaluate the effectiveness of file handle caching for a particular workload, issue the
: <codeph>PROFILE</codeph> statement in <cmdname>impala-shell</cmdname> or examine query
: profiles in the Impala web UI. Look for the ratio of <codeph>CachedFileHandlesHitCount</codeph>
: (ideally, should be high) to <codeph>CachedFileHandlesMissCount</codeph> (ideally, should be low).
: Before starting any evaluation, run some representative queries to <q>warm up</q> the cache,
: because the first time each data file is accessed is always recorded as a cache miss.
I'm not sure this belongs here, but information about the cache across the whole impalad is available via the metrics page under impala-server:
impala-server.io.mgr.cached-file-handles-miss-count
impala-server.io.mgr.cached-file-handles-hit-count
The total number of file handles in the cache is:
impala-server.io.mgr.num-cached-file-handles
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 02:37:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
IMPALA-4623: [DOCS] Document file handle caching
Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Reviewed-on: http://gerrit.cloudera.org:8080/8200
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_known_issues.xml
M docs/topics/impala_scalability.xml
3 files changed, 92 insertions(+), 0 deletions(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 4
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 23:49:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 3: Code-Review+1
This looks right to me. Are we expecting any other reviewers?
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 23:22:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
http://gerrit.cloudera.org:8080/#/c/8200/1/docs/topics/impala_known_issues.xml@338
PS1, Line 338: continuously appended by an HDFS mechanism
> This also applies if an HDFS file is overwritten in place.
Done
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 1
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 20:48:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4623: [DOCS] Document file handle caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8200 )
Change subject: IMPALA-4623: [DOCS] Document file handle caching
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/158/
--
To view, visit http://gerrit.cloudera.org:8080/8200
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I261c29eff80dc376528bba29ffb7d8e0f895e25f
Gerrit-Change-Number: 8200
Gerrit-PatchSet: 3
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Mostafa Mokhtar <mm...@cloudera.com>
Gerrit-Comment-Date: Thu, 05 Oct 2017 23:45:58 +0000
Gerrit-HasComments: No