You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/14 16:31:43 UTC

[GitHub] [incubator-tvm] ANSHUMAN87 opened a new pull request #5067: [Relay] Empty Tuple should be considered as variable

ANSHUMAN87 opened a new pull request #5067: [Relay] Empty Tuple should be considered as variable
URL: https://github.com/apache/incubator-tvm/pull/5067
 
 
   @tqchen , @zhiics, @MarisaKirisame
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] ANSHUMAN87 closed pull request #5067: [Relay] Empty Tuple should be considered as variable

Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 closed pull request #5067: [Relay] Empty Tuple should be considered as variable
URL: https://github.com/apache/incubator-tvm/pull/5067
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] MarisaKirisame commented on issue #5067: [Relay] Empty Tuple should be considered as variable

Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on issue #5067: [Relay] Empty Tuple should be considered as variable
URL: https://github.com/apache/incubator-tvm/pull/5067#issuecomment-599106842
 
 
   Is there any reason that it shouldnt be considered as a constant?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] MarisaKirisame commented on issue #5067: [Relay] Empty Tuple should be considered as variable

Posted by GitBox <gi...@apache.org>.
MarisaKirisame commented on issue #5067: [Relay] Empty Tuple should be considered as variable
URL: https://github.com/apache/incubator-tvm/pull/5067#issuecomment-599233555
 
 
   @ANSHUMAN87 it is impossible to modify a tuple.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5067: [Relay] Empty Tuple should be considered as variable

Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5067: [Relay] Empty Tuple should be considered as variable
URL: https://github.com/apache/incubator-tvm/pull/5067#issuecomment-600274463
 
 
   > @ANSHUMAN87 it is impossible to modify a tuple.
   
   @MarisaKirisame, @zhiics  : Extremely sorry for late reply. I believe there was some temp changes in my workspace, which led to such conclusion. Closing the PR. Thanks for your help!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-tvm] ANSHUMAN87 commented on issue #5067: [Relay] Empty Tuple should be considered as variable

Posted by GitBox <gi...@apache.org>.
ANSHUMAN87 commented on issue #5067: [Relay] Empty Tuple should be considered as variable
URL: https://github.com/apache/incubator-tvm/pull/5067#issuecomment-599172805
 
 
   @MarisaKirisame , @zhiics : Thanks for reviewing the changes. I am sorry i did not add test case this time cause i thought the test case wont be a valid scenario to represent to a user.
   
   I found this problem while reviewing code for another issue.
   To explain the background of it. Please consider below points.
   1:> Tuple as mostly adapted datatype does not allow any of the member to get modified once created(position and pointers), so provided that Empty Tuple is a constant.
   2:> But in TVM context, the Tuples allows its member to get modified, even after creation, so provided that Empty Tuple is a variable(Get modified afterwards).
   
   Please correct me if i am wrong at any point.
   
   I just handled for the fold_constant, as it was part of my analysis currently.
   
   But in my personal opinion, all Tuple Nodes should be Immutable.
   If you think TVM should implement Tuple as Immutable, i will close this PR(there is no point of checking for Empty Tuple as it becomes constant, once created)
   
   Please provide your valuable opinions. Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services