You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2013/03/05 00:19:56 UTC
Review Request: appname need to be persisted on SLA event table by SLA
status event
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9739/
-----------------------------------------------------------
Review request for oozie.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1246
This addresses bug OOZIE_1246.
https://issues.apache.org/jira/browse/OOZIE_1246
Diffs
-----
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1452464
trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1452464
Diff: https://reviews.apache.org/r/9739/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira
Re: Review Request: appname need to be persisted on SLA event table by SLA
status event
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9739/#review18091
-----------------------------------------------------------
Ship it!
Ship It!
- Virag Kothari
On March 4, 2013, 11:19 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9739/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 11:19 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1246
>
>
> This addresses bug OOZIE_1246.
> https://issues.apache.org/jira/browse/OOZIE_1246
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1452464
> trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1452464
>
> Diff: https://reviews.apache.org/r/9739/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: appname need to be persisted on SLA event table by SLA
status event
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9739/#review18092
-----------------------------------------------------------
I realized I forgot to give one comment earlier.
Related to 1189 but can be done as part of this patch
In OozieCLI,
createSLAoptions(),
{
Option filter = new Option(FILTER_OPTION, true, "filter of SLA events");
}
Specify what filter options are available like slaid, appname
- Virag Kothari
On March 4, 2013, 11:19 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9739/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 11:19 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1246
>
>
> This addresses bug OOZIE_1246.
> https://issues.apache.org/jira/browse/OOZIE_1246
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1452464
> trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1452464
>
> Diff: https://reviews.apache.org/r/9739/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: appname need to be persisted on SLA event table by SLA
status event
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
> On March 15, 2013, 11:33 p.m., Virag Kothari wrote:
> > This patch looks good
> >
> > Couple of comments not regarding to the patch but can be included in this patch
> >
> > 1) Group is shown as blank in registration event, would be good to populate it
> > 2) User and group are seen as blank in status event, would be good to set them
thx for comments, Virag.
discussed with him and did investigation. both issues have been there before this patch.
>1) Group is shown as blank in registration event, would be good to populate it
at local installation on Mac, group name of coord job submitter is not persisted properly and becomes null. thus, group name is not obtained properly for SLA event,
I opened OOZIE-1275 for that.
I double-checked this in our QA cluster where oozie server and client on different nodes with Rhel, and confirmed it works fine.
>2) User and group are seen as blank in status event, would be good to set them
SLAEvent is created in Xcommand of coord actions, but coord action bean doesn't include user and group, thus need another DB call to get these.
after discussing Virag, I come to know there will be change in JPAExecutor related to job/sla notification, which could also fetch user/group name, thus, we will revisit this point.
given this, this patch is ready to go in.
- Ryota
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9739/#review18013
-----------------------------------------------------------
On March 4, 2013, 11:19 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9739/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 11:19 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1246
>
>
> This addresses bug OOZIE_1246.
> https://issues.apache.org/jira/browse/OOZIE_1246
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1452464
> trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1452464
>
> Diff: https://reviews.apache.org/r/9739/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: appname need to be persisted on SLA event table by SLA
status event
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9739/#review18013
-----------------------------------------------------------
This patch looks good
Couple of comments not regarding to the patch but can be included in this patch
1) Group is shown as blank in registration event, would be good to populate it
2) User and group are seen as blank in status event, would be good to set them
- Virag Kothari
On March 4, 2013, 11:19 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9739/
> -----------------------------------------------------------
>
> (Updated March 4, 2013, 11:19 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/OOZIE-1246
>
>
> This addresses bug OOZIE_1246.
> https://issues.apache.org/jira/browse/OOZIE_1246
>
>
> Diffs
> -----
>
> trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1452464
> trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1452464
>
> Diff: https://reviews.apache.org/r/9739/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: appname need to be persisted on SLA event table by SLA
status event
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9739/
-----------------------------------------------------------
(Updated March 19, 2013, 6:31 p.m.)
Review request for oozie.
Changes
-------
accomodated Virag's comment, thanks. will upload patch to JIRA as well.
Description
-------
https://issues.apache.org/jira/browse/OOZIE-1246
This addresses bug OOZIE_1246.
https://issues.apache.org/jira/browse/OOZIE_1246
Diffs (updated)
-----
trunk/client/src/main/java/org/apache/oozie/cli/OozieCLI.java 1457222
trunk/core/src/main/java/org/apache/oozie/SLAEventBean.java 1457222
trunk/core/src/main/java/org/apache/oozie/util/db/SLADbOperations.java 1457222
Diff: https://reviews.apache.org/r/9739/diff/
Testing
-------
tested locally
Thanks,
Ryota Egashira