You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by ji...@apache.org on 2019/05/28 07:35:08 UTC

[flink] 02/02: [hotfix][python]fix command error for python API doc, and function call bug in table environment.

This is an automated email from the ASF dual-hosted git repository.

jincheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/flink.git

commit 8510e294802c096418cdc121b21d64de630c201f
Author: sunjincheng121 <su...@gmail.com>
AuthorDate: Tue May 28 15:26:14 2019 +0800

    [hotfix][python]fix command error for python API doc, and function call bug in table environment.
---
 docs/ops/cli.md                                                         | 2 +-
 docs/ops/cli.zh.md                                                      | 2 +-
 .../src/main/java/org/apache/flink/client/cli/CliFrontend.java          | 2 +-
 .../src/main/java/org/apache/flink/client/python/PythonUtil.java        | 2 +-
 flink-python/pyflink/table/table_environment.py                         | 2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/ops/cli.md b/docs/ops/cli.md
index 505207d..ab1fd16 100644
--- a/docs/ops/cli.md
+++ b/docs/ops/cli.md
@@ -121,7 +121,7 @@ These examples about how to submit a job in CLI.
 
 -   Run Python Table program in detached mode:
 
-        ./bin/flink run -d examples/python/table/batch/word_count.py -j <path/to/flink-table.jar>
+        ./bin/flink run -d -py examples/python/table/batch/word_count.py -j <path/to/flink-table.jar>
 
 -   Run Python Table program on a specific JobManager:
 
diff --git a/docs/ops/cli.zh.md b/docs/ops/cli.zh.md
index 93f16fb..ec6001b 100644
--- a/docs/ops/cli.zh.md
+++ b/docs/ops/cli.zh.md
@@ -121,7 +121,7 @@ available.
 
 -   提交一个运行在detached模式下的Python Table的作业:
 
-        ./bin/flink run -d examples/python/table/batch/word_count.py -j <path/to/flink-table.jar>
+        ./bin/flink run -d -py examples/python/table/batch/word_count.py -j <path/to/flink-table.jar>
 
 -   提交一个运行在指定JobManager上的Python Table的作业:
 
diff --git a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java b/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
index c591e6e..fe641fe 100644
--- a/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
+++ b/flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java
@@ -786,7 +786,7 @@ public class CliFrontend {
 			entryPointClass = PythonDriver.class.getCanonicalName();
 		} else {
 			if (jarFilePath == null) {
-				throw new IllegalArgumentException("The program JAR file was not specified.");
+				throw new IllegalArgumentException("Java program should be specified a JAR file.");
 			}
 			jarFile = getJarFile(jarFilePath);
 			// Get assembler class
diff --git a/flink-clients/src/main/java/org/apache/flink/client/python/PythonUtil.java b/flink-clients/src/main/java/org/apache/flink/client/python/PythonUtil.java
index b9012a3..9fecd49 100644
--- a/flink-clients/src/main/java/org/apache/flink/client/python/PythonUtil.java
+++ b/flink-clients/src/main/java/org/apache/flink/client/python/PythonUtil.java
@@ -96,7 +96,7 @@ public final class PythonUtil {
 
 		// 1. setup temporary local directory for the user files
 		String tmpDir = System.getProperty("java.io.tmpdir") +
-			File.separator + "pyflink" + UUID.randomUUID();
+			File.separator + "pyflink" + File.separator + UUID.randomUUID();
 
 		Path tmpDirPath = new Path(tmpDir);
 		try {
diff --git a/flink-python/pyflink/table/table_environment.py b/flink-python/pyflink/table/table_environment.py
index 337a0e4..45e2688 100644
--- a/flink-python/pyflink/table/table_environment.py
+++ b/flink-python/pyflink/table/table_environment.py
@@ -374,7 +374,7 @@ class TableEnvironment(object):
                 j_execution_env, table_config._j_table_config)
             t_env = BatchTableEnvironment(j_tenv)
 
-        if table_config.parallelism is not None:
+        if table_config.parallelism() is not None:
             t_env._j_tenv.execEnv().setParallelism(table_config.parallelism())
 
         return t_env