You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by maver1ck <gi...@git.apache.org> on 2017/07/03 12:50:08 UTC
[GitHub] spark pull request #18515: [SPARK-21287] Ability to use Integer.MIN_VALUE as...
GitHub user maver1ck opened a pull request:
https://github.com/apache/spark/pull/18515
[SPARK-21287] Ability to use Integer.MIN_VALUE as a fetchSize
## What changes were proposed in this pull request?
FIX for https://issues.apache.org/jira/browse/SPARK-21287
## How was this patch tested?
Existing automated tests + manual tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/maver1ck/spark spark-21287
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18515.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18515
----
commit 97b6d7bc74b1895db0c772b4c0de726c6be2c3f0
Author: Maciej Bryński <ma...@brynski.pl>
Date: 2017-07-03T12:46:29Z
Update JDBCOptions.scala
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the issue:
https://github.com/apache/spark/pull/18515
See JIRA; I don't think we should allow this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18515
**[Test build #79100 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79100/testReport)** for PR 18515 at commit [`97b6d7b`](https://github.com/apache/spark/commit/97b6d7bc74b1895db0c772b4c0de726c6be2c3f0).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18515
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81467/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VAL...
Posted by dongjoon-hyun <gi...@git.apache.org>.
Github user dongjoon-hyun commented on a diff in the pull request:
https://github.com/apache/spark/pull/18515#discussion_r125545614
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ---
@@ -103,10 +103,11 @@ class JDBCOptions(
s" and '$JDBC_NUM_PARTITIONS' are required.")
val fetchSize = {
val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt
- require(size >= 0,
+ require(size >= 0 || size == Integer.MIN_VALUE,
--- End diff --
+1 for @gatorsmile 's suggestion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VAL...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18515
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18515
**[Test build #79100 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79100/testReport)** for PR 18515 at commit [`97b6d7b`](https://github.com/apache/spark/commit/97b6d7bc74b1895db0c772b4c0de726c6be2c3f0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VAL...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18515#discussion_r125328090
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JDBCOptions.scala ---
@@ -103,10 +103,11 @@ class JDBCOptions(
s" and '$JDBC_NUM_PARTITIONS' are required.")
val fetchSize = {
val size = parameters.getOrElse(JDBC_BATCH_FETCH_SIZE, "0").toInt
- require(size >= 0,
+ require(size >= 0 || size == Integer.MIN_VALUE,
--- End diff --
It does not make sense to the other data sources except MySQL. If needed, we can introduce a dialect specific checking APIs in [JdbcDialect.scala](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/jdbc/JdbcDialects.scala)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18515
@maver1ck Any update?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18515
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18515
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79100/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18515
**[Test build #81467 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81467/testReport)** for PR 18515 at commit [`97b6d7b`](https://github.com/apache/spark/commit/97b6d7bc74b1895db0c772b4c0de726c6be2c3f0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18515
**[Test build #81467 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/81467/testReport)** for PR 18515 at commit [`97b6d7b`](https://github.com/apache/spark/commit/97b6d7bc74b1895db0c772b4c0de726c6be2c3f0).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18515: [SPARK-21287][SQL] Ability to use Integer.MIN_VALUE as a...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18515
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org