[GitHub] [spark] sunchao commented on a change in pull request #35378: [SPARK-38077] Fix binary compatibility issue with isDeterministic flag

[GitBox <gi...@apache.org>]

sunchao commented on a change in pull request #35378:
URL: https://github.com/apache/spark/pull/35378#discussion_r796326107



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/objects/objects.scala
##########
@@ -371,6 +384,18 @@ case class Invoke(
     }
 
   private lazy val encodedFunctionName = ScalaReflection.encodeFieldNameToIdentifier(functionName)
+  private var isDeterministic: Boolean = true

Review comment:
       Hmm I'm not sure whether there's a better way. I tried to make the parameter non-default but then it seems will break the API compatibility.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org