[jira] [Commented] (PHOENIX-5770) Logging framework for keeping track of alive Phoenix connections

["Hadoop QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-5770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17056612#comment-17056612 ] 

Hadoop QA commented on PHOENIX-5770:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12996359/PHOENIX-5770-4.x-HBase-1.3.v1.patch
  against 4.x-HBase-1.3 branch at commit c69f78f124ef0d248a4106c374cbf631ab0b3be0.
  ATTACHMENT ID: 12996359

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 24 new or modified tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                    + "Setting to default value: " + DEFAULT_MAX_CONCURRENT_CONN_EXTRA_LOGGING_SAMPLING_RATE);
+    // Indicates that we want extra logging every xth time we hit the MAX_CONCURRENT_CONNECTIONS exception
+        String[] st1StringParts = stackTraceStrings[0].split(ESC_ST_TOTAL_COUNT_SEP)[0].split(ESC_BEG_ST_VALS);
+        String[] st2StringParts = stackTraceStrings[1].split(ESC_ST_TOTAL_COUNT_SEP)[0].split(ESC_BEG_ST_VALS);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.query.logging.MaxConcurrentConnectionsIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UserDefinedFunctionsIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3566//testReport/
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/3566//console

This message is automatically generated.

> Logging framework for keeping track of alive Phoenix connections
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-5770
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5770
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.15.0, 5.1.0
>            Reporter: Chinmay Kulkarni
>            Assignee: Chinmay Kulkarni
>            Priority: Major
>         Attachments: PHOENIX-5770-4.x-HBase-1.3.v1.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)