[jira] [Updated] (SOLR-12244) Inconsistent method names

["KuiLIU (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

KuiLIU updated SOLR-12244:
--------------------------
    Summary: Inconsistent method names  (was: Inconsistent method name)

> Inconsistent method names
> -------------------------
>
>                 Key: SOLR-12244
>                 URL: https://issues.apache.org/jira/browse/SOLR-12244
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: KuiLIU
>            Priority: Major
>
> The following method is named as "getShardNames".
> The methods is adding "sliceName" to "shardNames", thus the method name "addShardNames" should be more clear than "getShardNames" since "get" means getting something.
> {code:java}
>  public static void getShardNames(Integer numShards, List<String> shardNames) {
>      if (numShards == null)
>        throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "numShards" + " is a required param");
>      for (int i = 0; i < numShards; i++) {
>        final String sliceName = "shard" + (i + 1);
>        shardNames.add(sliceName);
>      }
>  
>    }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org