You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/08/05 13:02:38 UTC

[GitHub] [cordova-docs] mosabab opened a new pull request #1105: [iOS] Add missing information regarding CocoaPods

mosabab opened a new pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   iOS
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   [iOS] Add missing information regarding CocoaPods.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [ ] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] mosabab commented on pull request #1105: [iOS] Add missing information regarding CocoaPods

Posted by GitBox <gi...@apache.org>.
mosabab commented on pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105#issuecomment-669196080


   > Maybe have the message like this?
   > 
   > In the latest release for Cordova-iOS 6.x, which these docs are aiming for, it has a requirement that CocaPods has to be 1.8.0 or greater.
   
   You are right, but this is information of the documentation for iOS, and I think there is no need to specify the version in the main documentation like ios-deploy, because the installation code `sudo gem install cocoapods` will install the latest stable version which is for now 1.9.3 which is > 1.8.0


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] mosabab edited a comment on pull request #1105: [iOS] Add missing information regarding CocoaPods

Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105#issuecomment-669196080


   > Maybe have the message like this?
   > 
   > In the latest release for Cordova-iOS 6.x, which these docs are aiming for, it has a requirement that CocaPods has to be 1.8.0 or greater.
   
   You are right, but this is information of the documentation for iOS, and I think there is no need to specify the version in the main documentation like ios-deploy, because the installation code `sudo gem install cocoapods` will install the latest stable version which is for now 1.9.3 which is > 1.8.0
   
   And you can always specify the minimum version requirements in the new cordova-ios releases.
   
   Anyway, your suggest seems good to include.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] mosabab edited a comment on pull request #1105: [iOS] Add missing information regarding CocoaPods

Posted by GitBox <gi...@apache.org>.
mosabab edited a comment on pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105#issuecomment-669196080


   > Maybe have the message like this?
   > 
   > In the latest release for Cordova-iOS 6.x, which these docs are aiming for, it has a requirement that CocaPods has to be 1.8.0 or greater.
   
   You are right, but this is information of the documentation for iOS, and I think there is no need to specify the version in the main documentation like ios-deploy, because the installation code `sudo gem install cocoapods` will install the latest stable version which is for now 1.9.3 which is > 1.8.0
   
   And you can always specify the minimum version requirements in the new cordova-ios releases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek merged pull request #1105: [iOS] Add missing information regarding CocoaPods

Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] erisu commented on a change in pull request #1105: [iOS] Add missing information regarding CocoaPods

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105#discussion_r465721285



##########
File path: www/docs/en/dev/guide/platforms/ios/index.md
##########
@@ -75,6 +75,16 @@ To install it, run the following from command-line terminal:
 $ npm install -g ios-deploy
 ```
 
+### CocoaPods
+
+The [CocoaPods](https://cocoapods.org/#install) tools is needed to build iOS apps.

Review comment:
       ```suggestion
   The [CocoaPods](https://cocoapods.org/#install) tools is needed to build iOS apps. A minimum version of 1.8.0 is required but the latest release is always recommended.
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org


[GitHub] [cordova-docs] breautek commented on pull request #1105: [iOS] Add missing information regarding CocoaPods

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1105:
URL: https://github.com/apache/cordova-docs/pull/1105#issuecomment-669298708


   Tests passed, thank you for your contribution @mosabab ! :tada: 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org