[GitHub] [accumulo] ctubbsii commented on a change in pull request #1140: Deprecate cumbersome CLI scan options

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #1140: Deprecate cumbersome CLI scan options
URL: https://github.com/apache/accumulo/pull/1140#discussion_r281866009
 
 

 ##########
 File path: shell/src/main/java/org/apache/accumulo/shell/commands/ScanCommand.java
 ##########
 @@ -218,9 +218,15 @@ protected ScanInterpreter getInterpreter(final CommandLine cl, final String tabl
     Class<? extends ScanInterpreter> clazz = null;
     try {
       if (cl.hasOption(interpreterOpt.getOpt())) {
+        shellState.getReader().println(
+            "WARNING: Scan Interpreter option is deprecated and will be removed in 2.1.\n");
 
 Review comment:
   I think deprecation is reasonable, but I'm not too keen on promising removal in a non-major release. Shell commands seem like public API to me, and should probably be treated that way. '3.0' would be better.
   
   Also, I'm not sure if this is still the case, but I remember when I did the initial work on the shell that I tried to make the STDOUT be the result of the command being run, and STDERR (or at least, the logger, which can be configured to use STDERR) for informational stuff from the shell that isn't directly the output of a command. In principle, this would make it possible for scripting/automation, but I'm not sure if the shell has retained that design principle since the last time I did significant work on it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services