You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bartek Plotka <bw...@gmail.com> on 2015/06/01 08:12:47 UTC
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
-----------------------------------------------------------
(Updated June 1, 2015, 6:12 a.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
Updated after the 34816 changes.
Bugs: MESOS-2650
https://issues.apache.org/jira/browse/MESOS-2650
Repository: mesos
Description
-------
Added *ResourceEstimator* (RE) module interface.
Added *TestResourceEstimator* example module.
Added *TestResourceEstimator* module to typed_tests in *oversubscription_tests.cpp*
Diffs (updated)
-----
include/mesos/module/resource_estimator.hpp PRE-CREATION
src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
src/examples/test_resource_estimator_module.cpp PRE-CREATION
src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34662/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 1, 2015, 1:55 p.m., Jie Yu wrote:
> > Could you please split out the module definition for ResourceEstimator and make this patch not dependent on r34816? I need this patch to build Fixed Resource Estimator.
Can't we just get this small chain in a good shape and land it? :)
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86068
-----------------------------------------------------------
On May 31, 2015, 11:13 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 11:13 p.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
> Added *TestNoopResourceEstimator* module to typed_tests in *oversubscription_tests.cpp*
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
> src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Jie Yu <yu...@gmail.com>.
> On June 1, 2015, 8:55 p.m., Jie Yu wrote:
> > src/tests/module.hpp, lines 76-84
> > <https://reviews.apache.org/r/34662/diff/11/?file=975514#file975514line76>
> >
> > Not your fault. But I found this very unintuitive. It takes me quite a while to figure out why we need this.
> >
> > It would be more intuitive if we used template specification.
> >
> > ```
> > template <ResourceEstimator, TestNoopResourceEstimator>
> > class Module
> > {
> > static Try<ResourceEstimator*> create(const Option<std::string>& type)
> > {
> > ...
> > }
> > };
> > ```
>
> Niklas Nielsen wrote:
> When we don't type param the test, we won't need this overload (as far as I can grasp).
True. But "Try<T*> create(logging::Flags flags)" has the same issue. I cannot not tell what this function is used for (i.e., which module).
We don't have to solve it in this review. Just some thoughts on readability:)
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86068
-----------------------------------------------------------
On June 1, 2015, 6:13 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:13 a.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
> Added *TestNoopResourceEstimator* module to typed_tests in *oversubscription_tests.cpp*
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
> src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Niklas Nielsen <ni...@qni.dk>.
> On June 1, 2015, 1:55 p.m., Jie Yu wrote:
> > src/tests/module.hpp, lines 76-84
> > <https://reviews.apache.org/r/34662/diff/11/?file=975514#file975514line76>
> >
> > Not your fault. But I found this very unintuitive. It takes me quite a while to figure out why we need this.
> >
> > It would be more intuitive if we used template specification.
> >
> > ```
> > template <ResourceEstimator, TestNoopResourceEstimator>
> > class Module
> > {
> > static Try<ResourceEstimator*> create(const Option<std::string>& type)
> > {
> > ...
> > }
> > };
> > ```
When we don't type param the test, we won't need this overload (as far as I can grasp).
- Niklas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86068
-----------------------------------------------------------
On May 31, 2015, 11:13 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated May 31, 2015, 11:13 p.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
> Added *TestNoopResourceEstimator* module to typed_tests in *oversubscription_tests.cpp*
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
> src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86068
-----------------------------------------------------------
Could you please split out the module definition for ResourceEstimator and make this patch not dependent on r34816? I need this patch to build Fixed Resource Estimator.
src/tests/module.hpp
<https://reviews.apache.org/r/34662/#comment137966>
Not your fault. But I found this very unintuitive. It takes me quite a while to figure out why we need this.
It would be more intuitive if we used template specification.
```
template <ResourceEstimator, TestNoopResourceEstimator>
class Module
{
static Try<ResourceEstimator*> create(const Option<std::string>& type)
{
...
}
};
```
src/tests/module.hpp
<https://reviews.apache.org/r/34662/#comment137967>
const Option<std::string>& type please
src/tests/module.hpp
<https://reviews.apache.org/r/34662/#comment137968>
const logging::Flags& flags please
- Jie Yu
On June 1, 2015, 6:13 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 6:13 a.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
> Added *TestNoopResourceEstimator* module to typed_tests in *oversubscription_tests.cpp*
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
> src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86263
-----------------------------------------------------------
Ship it!
Modulo Jie's comments
- Niklas Nielsen
On June 1, 2015, 5:40 p.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated June 1, 2015, 5:40 p.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
-----------------------------------------------------------
(Updated June 2, 2015, 8:58 p.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
Jie Yu issues addressed.
Bugs: MESOS-2650
https://issues.apache.org/jira/browse/MESOS-2650
Repository: mesos
Description
-------
Added *ResourceEstimator* (RE) module interface.
Added *TestResourceEstimator* example module.
Diffs (updated)
-----
include/mesos/module/resource_estimator.hpp PRE-CREATION
src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
src/examples/test_resource_estimator_module.cpp PRE-CREATION
src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
Diff: https://reviews.apache.org/r/34662/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Bartek Plotka <bw...@gmail.com>.
> On June 2, 2015, 5:07 p.m., Jie Yu wrote:
> > src/tests/module.hpp, lines 76-79
> > <https://reviews.apache.org/r/34662/diff/14/?file=976049#file976049line76>
> >
> > Do we need this?
Nope, we deleted RE moduled test so in fact we don't - sorry.
- Bartek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86247
-----------------------------------------------------------
On June 2, 2015, 12:40 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 12:40 a.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/#review86247
-----------------------------------------------------------
Ship it!
src/examples/test_resource_estimator_module.cpp
<https://reviews.apache.org/r/34662/#comment138171>
Try<ResourceEstimator*> result = NoopResourceEstimator::create(None());
src/tests/module.hpp
<https://reviews.apache.org/r/34662/#comment138172>
Do we need this?
- Jie Yu
On June 2, 2015, 12:40 a.m., Bartek Plotka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34662/
> -----------------------------------------------------------
>
> (Updated June 2, 2015, 12:40 a.m.)
>
>
> Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
>
>
> Bugs: MESOS-2650
> https://issues.apache.org/jira/browse/MESOS-2650
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added *ResourceEstimator* (RE) module interface.
> Added *TestResourceEstimator* example module.
>
>
> Diffs
> -----
>
> include/mesos/module/resource_estimator.hpp PRE-CREATION
> src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
> src/examples/test_resource_estimator_module.cpp PRE-CREATION
> src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
> src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
> src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
>
> Diff: https://reviews.apache.org/r/34662/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Bartek Plotka
>
>
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
-----------------------------------------------------------
(Updated June 2, 2015, 12:40 a.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
Removed unused includes.
Bugs: MESOS-2650
https://issues.apache.org/jira/browse/MESOS-2650
Repository: mesos
Description
-------
Added *ResourceEstimator* (RE) module interface.
Added *TestResourceEstimator* example module.
Diffs (updated)
-----
include/mesos/module/resource_estimator.hpp PRE-CREATION
src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
src/examples/test_resource_estimator_module.cpp PRE-CREATION
src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
Diff: https://reviews.apache.org/r/34662/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
-----------------------------------------------------------
(Updated June 2, 2015, 12:28 a.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Bugs: MESOS-2650
https://issues.apache.org/jira/browse/MESOS-2650
Repository: mesos
Description
-------
Added *ResourceEstimator* (RE) module interface.
Added *TestResourceEstimator* example module.
Diffs (updated)
-----
include/mesos/module/resource_estimator.hpp PRE-CREATION
src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
src/examples/test_resource_estimator_module.cpp PRE-CREATION
src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34662/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
-----------------------------------------------------------
(Updated June 2, 2015, 12:19 a.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Changes
-------
Issue addressed.
Bugs: MESOS-2650
https://issues.apache.org/jira/browse/MESOS-2650
Repository: mesos
Description (updated)
-------
Added *ResourceEstimator* (RE) module interface.
Added *TestResourceEstimator* example module.
Diffs (updated)
-----
include/mesos/module/resource_estimator.hpp PRE-CREATION
src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
src/examples/test_resource_estimator_module.cpp PRE-CREATION
src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34662/diff/
Testing
-------
make check
Thanks,
Bartek Plotka
Re: Review Request 34662: Modularized ResourceEstimator and added
test for RE module
Posted by Bartek Plotka <bw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34662/
-----------------------------------------------------------
(Updated June 1, 2015, 6:13 a.m.)
Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod Kone.
Bugs: MESOS-2650
https://issues.apache.org/jira/browse/MESOS-2650
Repository: mesos
Description (updated)
-------
Added *ResourceEstimator* (RE) module interface.
Added *TestResourceEstimator* example module.
Added *TestNoopResourceEstimator* module to typed_tests in *oversubscription_tests.cpp*
Diffs
-----
include/mesos/module/resource_estimator.hpp PRE-CREATION
src/Makefile.am 9d1f0d5de2e7647a6677d86f5032ae1b79f1b241
src/examples/test_resource_estimator_module.cpp PRE-CREATION
src/module/manager.cpp 5fed1aa82f72aa55c8e4e946f5f458ee357162be
src/tests/module.hpp c379f01ae4e185960b8710b6a10626a3b8784fc8
src/tests/module.cpp c4f811998aef14ab247380318fab79f18672ab29
src/tests/oversubscription_tests.cpp ea5857cb579aa904fd05530684bdde51a0b3f27f
Diff: https://reviews.apache.org/r/34662/diff/
Testing
-------
make check
Thanks,
Bartek Plotka