[GitHub] [spark] dongjoon-hyun commented on a diff in pull request #42710: [SPARK-44996][K8S] `VolcanoFeatureStep` should not create `DefaultVolcanoClient` if not needed

["dongjoon-hyun (via GitHub)" <gi...@apache.org>]

dongjoon-hyun commented on code in PR #42710:
URL: https://github.com/apache/spark/pull/42710#discussion_r1308078497


##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/VolcanoFeatureStep.scala:
##########
@@ -46,7 +46,7 @@ private[spark] class VolcanoFeatureStep extends KubernetesDriverCustomFeatureCon
         "for executor.")
       return Seq.empty
     }
-    val client = new DefaultVolcanoClient
+    lazy val client = new DefaultVolcanoClient
     val template = kubernetesConf.getOption(POD_GROUP_TEMPLATE_FILE_KEY)
     val pg = template.map(client.podGroups.load(_).item).getOrElse(new PodGroup())

Review Comment:
   When `template` configuration is not given, Apache Spark will not create `DefaultVolcanoClient`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org