You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2019/12/12 08:03:39 UTC
[GitHub] [lucene-solr] chenkovsky commented on issue #895: LUCENE-8985:
SynonymGraphFilter cannot handle input stream with tokens filtered.
chenkovsky commented on issue #895: LUCENE-8985: SynonymGraphFilter cannot handle input stream with tokens filtered.
URL: https://github.com/apache/lucene-solr/pull/895#issuecomment-564895096
@mikemccand I agree that separating refactoring code into another pull request is better. actually I tried it at the beginning. But I find that I have to pay much more effort to reach this aim. I find that the old code is trying to maintain the state of looking ahead tokens in a complex way. the bug hides in this complex way(a lot of liveToken if else statement), I cannot tell if I fixed the bug, are there any more bugs. So I simplify the implementation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org