[jira] [Commented] (AVRO-1692) Allow more than one logical type for a Java class

["Sachin Goyal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AVRO-1692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15130921#comment-15130921 ] 

Sachin Goyal commented on AVRO-1692:
------------------------------------

I guess we can now close https://issues.apache.org/jira/browse/AVRO-695 too?

> Allow more than one logical type for a Java class
> -------------------------------------------------
>
>                 Key: AVRO-1692
>                 URL: https://issues.apache.org/jira/browse/AVRO-1692
>             Project: Avro
>          Issue Type: Task
>          Components: java
>            Reporter: Ryan Blue
>            Assignee: Ryan Blue
>             Fix For: 1.8.0
>
>         Attachments: AVRO-1692.1.patch, AVRO-1692.2.patch
>
>
> The initial logical types implementation assumed that there would only be one logical type per concrete class and kept a lookup table from class to conversion. There are cases where this assumption doesn't work. For example, both time-millis and time-micros can be represented by the same class, LocalTime, and the write path should use the correct logical type's conversion depending on the schema.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)