You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2019/12/26 14:44:50 UTC
[GitHub] [kylin] xiacongling opened a new pull request #1024: KYLIN-4315 use
metadata numRows in beeline client for quick row counting
xiacongling opened a new pull request #1024: KYLIN-4315 use metadata numRows in beeline client for quick row counting
URL: https://github.com/apache/kylin/pull/1024
see https://issues.apache.org/jira/browse/KYLIN-4315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen commented on a change in pull request #1024:
KYLIN-4315 use metadata numRows in beeline client for quick row counting
Posted by GitBox <gi...@apache.org>.
nichunen commented on a change in pull request #1024: KYLIN-4315 use metadata numRows in beeline client for quick row counting
URL: https://github.com/apache/kylin/pull/1024#discussion_r368987064
##########
File path: source-hive/src/main/java/org/apache/kylin/source/hive/BeelineHiveClient.java
##########
@@ -272,6 +261,9 @@ private void extractTableParam(ResultSet resultSet, HiveTableMetaBuilder builder
if ("numFiles".equals(resultSet.getString(2).trim())) {
builder.setFileNum(Long.parseLong(resultSet.getString(3).trim()));
}
+ if ("numRows".equals(resultSet.getString(2).trim())) {
+ builder.setRowNum(Long.parseLong(resultSet.getString(3).trim()));
Review comment:
Is it certain that "numRows" will always be gotten in hive table's meta? As I know, there is possibility that it be -1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1024: KYLIN-4315 use
metadata numRows in beeline client for quick row counting
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1024: KYLIN-4315 use metadata numRows in beeline client for quick row counting
URL: https://github.com/apache/kylin/pull/1024#issuecomment-569073587
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1024?src=pr&el=h1) Report
> :exclamation: No coverage uploaded for pull request base (`master@c58c9bf`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference#section-missing-base-commit).
> The diff coverage is `0%`.
[](https://codecov.io/gh/apache/kylin/pull/1024?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1024 +/- ##
========================================
Coverage ? 25.1%
Complexity ? 6179
========================================
Files ? 1433
Lines ? 87269
Branches ? 12218
========================================
Hits ? 21910
Misses ? 63210
Partials ? 2149
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1024?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/kylin/source/hive/HiveTableMetaBuilder.java](https://codecov.io/gh/apache/kylin/pull/1024/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVUYWJsZU1ldGFCdWlsZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...rg/apache/kylin/source/hive/BeelineHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1024/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0JlZWxpbmVIaXZlQ2xpZW50LmphdmE=) | `4% <0%> (ø)` | `5 <0> (?)` | |
| [...va/org/apache/kylin/source/hive/HiveTableMeta.java](https://codecov.io/gh/apache/kylin/pull/1024/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVUYWJsZU1ldGEuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
| [...va/org/apache/kylin/source/hive/CLIHiveClient.java](https://codecov.io/gh/apache/kylin/pull/1024/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0NMSUhpdmVDbGllbnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1024?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1024?src=pr&el=footer). Last update [c58c9bf...9e7c478](https://codecov.io/gh/apache/kylin/pull/1024?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services