You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (JIRA)" <ji...@apache.org> on 2012/12/19 07:01:14 UTC

[jira] [Comment Edited] (HBASE-7226) HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=

    [ https://issues.apache.org/jira/browse/HBASE-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535683#comment-13535683 ] 

Lars Hofhansl edited comment on HBASE-7226 at 12/19/12 5:59 AM:
----------------------------------------------------------------

Moving to next point release for now. We can pull it back if we like.
                
      was (Author: lhofhansl):
    Moving to next point release for now. We can pull it back and we like.
                  
> HRegion.checkAndMutate uses incorrect comparison result for <, <=, > and >=
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-7226
>                 URL: https://issues.apache.org/jira/browse/HBASE-7226
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 0.94.2
>         Environment: 0.94.2
>            Reporter: Feng Honghua
>            Priority: Minor
>             Fix For: 0.94.5
>
>         Attachments: HRegion_HBASE_7226_0.94.2.patch
>
>   Original Estimate: 10m
>  Remaining Estimate: 10m
>
> in HRegion.checkAndMutate, incorrect comparison results are used for <, <=, > and >=, as below:
>           switch (compareOp) {
>           case LESS:
>             matches = compareResult <= 0;  // should be '<' here
>             break;
>           case LESS_OR_EQUAL:
>             matches = compareResult < 0;  // should be '<=' here
>             break;
>           case EQUAL:
>             matches = compareResult == 0;
>             break;
>           case NOT_EQUAL:
>             matches = compareResult != 0;
>             break;
>           case GREATER_OR_EQUAL:
>             matches = compareResult > 0;  // should be '>=' here
>             break;
>           case GREATER:
>             matches = compareResult >= 0;  // should be '>' here
>             break;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira