You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "DaisyModi (via GitHub)" <gi...@apache.org> on 2026/03/26 17:17:36 UTC
[PR] [GOBBLIN-2247] Increase RPC retry budget to 10 min for Temporal gRPC throttling [gobblin]
DaisyModi opened a new pull request, #4180:
URL: https://github.com/apache/gobblin/pull/4180
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-2247
### Description
- [x] Here are some details about my PR, including screenshots (if applicable):
Follow-up to #4176. The previous RPC retry defaults (`initialInterval=500ms`, `maximumInterval=30s`, `maximumAttempts=10`) provided ~2.5 minutes of cumulative retry budget — only marginally better than the Temporal SDK's built-in 1-minute expiration default (`DefaultStubServiceOperationRpcRetryOptions`). This was insufficient to survive sustained throttle bursts of up to 10 minutes observed in production.
**Changes to default values in `GobblinTemporalConfigurationKeys`:**
| Parameter | Old | New | Rationale |
|---|---|---|---|
| `initialInterval` | 500ms | 1000ms | Less aggressive on a throttled server |
| `maximumInterval` | 30s | 60s | Sufficient spacing during sustained throttling |
| `backoffCoefficient` | 2.0 | 2.0 | Unchanged |
| `maximumAttempts` | 10 | 15 | Fewer attempts needed thanks to larger max interval |
With `initialInterval=1s`, `coefficient=2.0`, `maximumInterval=60s`, `maximumAttempts=15`:
- Attempts 1–6: 1 + 2 + 4 + 8 + 16 + 32 = 63s (hits 60s cap at attempt 7)
- Attempts 7–15: 9 × 60s = 540s
- **Total: ~603s (~10 min)**
All values remain configurable via Typesafe Config.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Config-only change — no logic changes. `buildRpcRetryOptions` is unchanged; only the default constants are tuned.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2247] Increase RPC retry budget to 10 min for Temporal gRPC throttling [gobblin]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4180:
URL: https://github.com/apache/gobblin/pull/4180#issuecomment-4155609692
## [Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4180?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 38.75%. Comparing base ([`26406a8`](https://app.codecov.io/gh/apache/gobblin/commit/26406a863688e289063e92bd421bf866f84e5586?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`911a571`](https://app.codecov.io/gh/apache/gobblin/commit/911a5715b01c51abe7add424852b77addb558610?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 5 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4180 +/- ##
============================================
- Coverage 43.26% 38.75% -4.52%
+ Complexity 2583 1600 -983
============================================
Files 516 389 -127
Lines 22087 16030 -6057
Branches 2505 1590 -915
============================================
- Hits 9557 6212 -3345
+ Misses 11566 9319 -2247
+ Partials 964 499 -465
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4180?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [GOBBLIN-2247] Increase RPC retry budget to 10 min for Temporal gRPC throttling [gobblin]
Posted by "Blazer-007 (via GitHub)" <gi...@apache.org>.
Blazer-007 merged PR #4180:
URL: https://github.com/apache/gobblin/pull/4180
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org