You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by gi...@git.apache.org on 2017/09/16 09:39:34 UTC

[GitHub] rhtyd commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events

rhtyd commented on a change in pull request #2058: CLOUDSTACK-9888: Duplicate usage while processing usage events 
URL: https://github.com/apache/cloudstack/pull/2058#discussion_r139283005
 
 

 ##########
 File path: usage/src/com/cloud/usage/UsageManagerImpl.java
 ##########
 @@ -1054,8 +1054,6 @@ private void createVMHelperEvent(UsageEventVO event) {
 
         if (EventTypes.EVENT_VM_START.equals(event.getType())) {
             // create a new usage_VM_instance row for this VM
-            try {
 
 Review comment:
   Fix indentations if you want to remove try-catch, also add a test?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services