You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/14 07:21:10 UTC

[GitHub] [shardingsphere] FlyingZC opened a new pull request, #22165: Fix alter transaction rule error

FlyingZC opened a new pull request, #22165:
URL: https://github.com/apache/shardingsphere/pull/22165

   Changes proposed in this pull request:
     - Fix alter transaction rule error
     
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [x] I have self-reviewed the commit code.
   - [x] I have (or in comment I request) added corresponding labels for the pull request.
   - [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [x] I have made corresponding changes to the documentation.
   - [x] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] strongduanmu merged pull request #22165: Fix alter transaction rule error

Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22165:
URL: https://github.com/apache/shardingsphere/pull/22165


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] FlyingZC commented on pull request #22165: Fix alter transaction rule error

Posted by GitBox <gi...@apache.org>.
FlyingZC commented on PR #22165:
URL: https://github.com/apache/shardingsphere/pull/22165#issuecomment-1313206070

   Test cases:
   **1. alter transaction rule**
   ```sql
   ALTER TRANSACTION RULE
   (
       DEFAULT='XA',
       TYPE(NAME='Atomikos')
   );
   ```
   
   **2.add resource**
   ```sql
   CREATE DATABASE test;
   
   REGISTER STORAGE UNIT ds_0 (
       URL="jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false",
       USER="root",
       PASSWORD="x",
       PROPERTIES("maximumPoolSize"="10","idleTimeout"="30000")
   ), ds_1 (
       URL="jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false",
       USER="root",
       PASSWORD="x",
       PROPERTIES("maximumPoolSize"="10","idleTimeout"="30000")
   );
   
   REGISTER STORAGE UNIT ds_2 (
       URL="jdbc:mysql://127.0.0.1:3306/demo_ds_2?serverTimezone=UTC&useSSL=false",
       USER="root",
       PASSWORD="x",
       PROPERTIES("maximumPoolSize"="10","idleTimeout"="30000")
   );
   ```
   
   **3.add resource2**
   ```sql
   CREATE DATABASE test2;
   
   use test2;
   
   REGISTER STORAGE UNIT ds_0 (
       URL="jdbc:mysql://127.0.0.1:3306/demo_ds_0?serverTimezone=UTC&useSSL=false",
       USER="root",
       PASSWORD="x",
       PROPERTIES("maximumPoolSize"="10","idleTimeout"="30000")
   ), ds_1 (
       URL="jdbc:mysql://127.0.0.1:3306/demo_ds_1?serverTimezone=UTC&useSSL=false",
       USER="root",
       PASSWORD="x",
       PROPERTIES("maximumPoolSize"="10","idleTimeout"="30000")
   );
   
   REGISTER STORAGE UNIT ds_2 (
       URL="jdbc:mysql://127.0.0.1:3306/demo_ds_2?serverTimezone=UTC&useSSL=false",
       USER="root",
       PASSWORD="x",
       PROPERTIES("maximumPoolSize"="10","idleTimeout"="30000")
   );
   
   ```
   
   **4.close resource**
   ```sql
   drop database test2;
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] FlyingZC commented on pull request #22165: Fix alter transaction rule error

Posted by GitBox <gi...@apache.org>.
FlyingZC commented on PR #22165:
URL: https://github.com/apache/shardingsphere/pull/22165#issuecomment-1313233403

   <img width="1007" alt="image" src="https://user-images.githubusercontent.com/19788130/201605281-0a0315de-3471-4841-b701-5cffcf3a0bdc.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org