You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "parthpandya00 (via GitHub)" <gi...@apache.org> on 2024/08/18 16:47:28 UTC

[PR] [fix][client] fix NPE in ConsumerBase.callMessageListener when unAckedMessageTracker is null [pulsar]

parthpandya00 opened a new pull request, #23195:
URL: https://github.com/apache/pulsar/pull/23195

   Fixes #23193 
   
   ### Modifications
   
   I have added a null check invoking the method `add` on the `unAckedMessageTracker`
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [T] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][client] fix NPE in ConsumerBase.callMessageListener when unAckedMessageTracker is null [pulsar]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23195:
URL: https://github.com/apache/pulsar/pull/23195#issuecomment-2295323596

   @parthpandya00 Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][client] fix NPE in ConsumerBase.callMessageListener when unAckedMessageTracker is null [pulsar]

Posted by "parthpandya00 (via GitHub)" <gi...@apache.org>.
parthpandya00 closed pull request #23195: [fix][client] fix NPE in ConsumerBase.callMessageListener when unAckedMessageTracker is null
URL: https://github.com/apache/pulsar/pull/23195


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][client] fix NPE in ConsumerBase.callMessageListener when unAckedMessageTracker is null [pulsar]

Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #23195:
URL: https://github.com/apache/pulsar/pull/23195#issuecomment-2295369996

   Thanks for the contribution! This PR would prevent the NPE, but it is possible that the possible race condition in closing a consumer should be handled in a proper way so that the NPE would be prevented at a different level. Before merging this, we should understand why the NPE happens in the first place.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix][client] fix NPE in ConsumerBase.callMessageListener when unAckedMessageTracker is null [pulsar]

Posted by "parthpandya00 (via GitHub)" <gi...@apache.org>.
parthpandya00 commented on PR #23195:
URL: https://github.com/apache/pulsar/pull/23195#issuecomment-2296833302

   Hi @lhotari, I appreciate your feedback. Given my current understanding of the codebase, I realise I might not yet be equipped to identify the race condition you mentioned. I would like to familiarise myself more with the project by tackling some other issues, which will help me gradually build a stronger foundation. Thank you for your guidance!
   I shall close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org