You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2023/01/12 06:51:03 UTC
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1307: refactor(log): use LOG_INFO_F instead of LOG_INFO (1/3)
empiredan commented on code in PR #1307:
URL: https://github.com/apache/incubator-pegasus/pull/1307#discussion_r1067730898
##########
src/replica/mutation_log.cpp:
##########
@@ -1656,51 +1649,51 @@ int mutation_log::garbage_collection(const replica_log_info_map &gc_condition,
}
if (stop_gc_decree_gap > 0) {
- LOG_INFO("gc_shared: deleted some files, file_count_limit = %d, "
- "reserved_log_count = %d, reserved_log_size = %" PRId64 ", "
- "reserved_smallest_log = %d, reserved_largest_log = %d, "
- "to_delete_log_count = %d, to_delete_log_size = %" PRId64 ", "
- "deleted_log_count = %d, deleted_log_size = %" PRId64 ", "
- "deleted_smallest_log = %d, deleted_largest_log = %d, "
- "stop_gc_log_index = %d, stop_gc_replica_count = %d, "
- "stop_gc_replica = %d.%d, stop_gc_decree_gap = %" PRId64 ", "
- "stop_gc_garbage_max_decree = %" PRId64 ", stop_gc_log_max_decree = %" PRId64 "",
- file_count_limit,
- reserved_log_count,
- reserved_log_size,
- reserved_smallest_log,
- reserved_largest_log,
- to_delete_log_count,
- to_delete_log_size,
- deleted_log_count,
- deleted_log_size,
- deleted_smallest_log,
- deleted_largest_log,
- stop_gc_log_index,
- (int)prevent_gc_replicas.size(),
- stop_gc_replica.get_app_id(),
- stop_gc_replica.get_partition_index(),
- stop_gc_decree_gap,
- stop_gc_garbage_max_decree,
- stop_gc_log_max_decree);
+ LOG_INFO_F("gc_shared: deleted some files, file_count_limit = {}, "
+ "reserved_log_count = {}, reserved_log_size = {}, "
+ "reserved_smallest_log = {}, reserved_largest_log = {}, "
+ "to_delete_log_count = {}, to_delete_log_size = {}, "
+ "deleted_log_count = {}, deleted_log_size = {}, "
+ "deleted_smallest_log = {}, deleted_largest_log = {}, "
+ "stop_gc_log_index = {}, stop_gc_replica_count = {}, "
+ "stop_gc_replica = {}.{}, stop_gc_decree_gap = {}, "
Review Comment:
```suggestion
"stop_gc_replica = {}, stop_gc_decree_gap = {}, "
```
##########
src/replica/test/mock_utils.h:
##########
@@ -204,9 +204,9 @@ class mock_replica : public replica
void generate_backup_checkpoint(cold_backup_context_ptr backup_context) override
{
if (backup_context->status() != ColdBackupCheckpointing) {
- LOG_INFO("%s: ignore generating backup checkpoint because backup_status = %s",
- backup_context->name,
- cold_backup_status_to_string(backup_context->status()));
+ LOG_INFO_F("ignore generating backup checkpoint because backup_status = {}",
Review Comment:
```suggestion
LOG_INFO_F("{}: ignore generating backup checkpoint because backup_status = {}",
```
##########
src/replica/mutation_log.cpp:
##########
@@ -1570,34 +1564,33 @@ int mutation_log::garbage_collection(const replica_log_info_map &gc_condition,
if (mark_it == files.rend()) {
// no file to delete
if (stop_gc_decree_gap > 0) {
- LOG_INFO("gc_shared: no file can be deleted, file_count_limit = %d, "
- "reserved_log_count = %d, reserved_log_size = %" PRId64 ", "
- "reserved_smallest_log = %d, reserved_largest_log = %d, "
- "stop_gc_log_index = %d, stop_gc_replica_count = %d, "
- "stop_gc_replica = %d.%d, stop_gc_decree_gap = %" PRId64 ", "
- "stop_gc_garbage_max_decree = %" PRId64 ", stop_gc_log_max_decree = %" PRId64
- "",
- file_count_limit,
- reserved_log_count,
- reserved_log_size,
- reserved_smallest_log,
- reserved_largest_log,
- stop_gc_log_index,
- (int)prevent_gc_replicas.size(),
- stop_gc_replica.get_app_id(),
- stop_gc_replica.get_partition_index(),
- stop_gc_decree_gap,
- stop_gc_garbage_max_decree,
- stop_gc_log_max_decree);
+ LOG_INFO_F("gc_shared: no file can be deleted, file_count_limit = {}, "
+ "reserved_log_count = {}, reserved_log_size = {}, "
+ "reserved_smallest_log = {}, reserved_largest_log = {}, "
+ "stop_gc_log_index = {}, stop_gc_replica_count = {}, "
+ "stop_gc_replica = {}.{}, stop_gc_decree_gap = {}, "
+ "stop_gc_garbage_max_decree = {}, stop_gc_log_max_decree = {}",
+ file_count_limit,
+ reserved_log_count,
+ reserved_log_size,
+ reserved_smallest_log,
+ reserved_largest_log,
+ stop_gc_log_index,
+ prevent_gc_replicas.size(),
+ stop_gc_replica.get_app_id(),
+ stop_gc_replica.get_partition_index(),
Review Comment:
```suggestion
stop_gc_replica,
```
##########
src/replica/mutation_log.cpp:
##########
@@ -1570,34 +1564,33 @@ int mutation_log::garbage_collection(const replica_log_info_map &gc_condition,
if (mark_it == files.rend()) {
// no file to delete
if (stop_gc_decree_gap > 0) {
- LOG_INFO("gc_shared: no file can be deleted, file_count_limit = %d, "
- "reserved_log_count = %d, reserved_log_size = %" PRId64 ", "
- "reserved_smallest_log = %d, reserved_largest_log = %d, "
- "stop_gc_log_index = %d, stop_gc_replica_count = %d, "
- "stop_gc_replica = %d.%d, stop_gc_decree_gap = %" PRId64 ", "
- "stop_gc_garbage_max_decree = %" PRId64 ", stop_gc_log_max_decree = %" PRId64
- "",
- file_count_limit,
- reserved_log_count,
- reserved_log_size,
- reserved_smallest_log,
- reserved_largest_log,
- stop_gc_log_index,
- (int)prevent_gc_replicas.size(),
- stop_gc_replica.get_app_id(),
- stop_gc_replica.get_partition_index(),
- stop_gc_decree_gap,
- stop_gc_garbage_max_decree,
- stop_gc_log_max_decree);
+ LOG_INFO_F("gc_shared: no file can be deleted, file_count_limit = {}, "
+ "reserved_log_count = {}, reserved_log_size = {}, "
+ "reserved_smallest_log = {}, reserved_largest_log = {}, "
+ "stop_gc_log_index = {}, stop_gc_replica_count = {}, "
+ "stop_gc_replica = {}.{}, stop_gc_decree_gap = {}, "
Review Comment:
```suggestion
"stop_gc_replica = {}, stop_gc_decree_gap = {}, "
```
##########
src/replica/mutation_log_replay.cpp:
##########
@@ -50,9 +49,7 @@ namespace replication {
start_offset = static_cast<size_t>(end_offset - log->start_offset());
}
- LOG_INFO("finish to replay mutation log (%s) [err: %s]",
- log->path().c_str(),
- err.description().c_str());
+ LOG_INFO_F("finish to replay mutation log ({}) [err: {}]", log->path(), err.description());
Review Comment:
```suggestion
LOG_INFO_F("finish to replay mutation log ({}) [err: {}]", log->path(), err);
```
##########
src/replica/mutation_log.cpp:
##########
@@ -1656,51 +1649,51 @@ int mutation_log::garbage_collection(const replica_log_info_map &gc_condition,
}
if (stop_gc_decree_gap > 0) {
- LOG_INFO("gc_shared: deleted some files, file_count_limit = %d, "
- "reserved_log_count = %d, reserved_log_size = %" PRId64 ", "
- "reserved_smallest_log = %d, reserved_largest_log = %d, "
- "to_delete_log_count = %d, to_delete_log_size = %" PRId64 ", "
- "deleted_log_count = %d, deleted_log_size = %" PRId64 ", "
- "deleted_smallest_log = %d, deleted_largest_log = %d, "
- "stop_gc_log_index = %d, stop_gc_replica_count = %d, "
- "stop_gc_replica = %d.%d, stop_gc_decree_gap = %" PRId64 ", "
- "stop_gc_garbage_max_decree = %" PRId64 ", stop_gc_log_max_decree = %" PRId64 "",
- file_count_limit,
- reserved_log_count,
- reserved_log_size,
- reserved_smallest_log,
- reserved_largest_log,
- to_delete_log_count,
- to_delete_log_size,
- deleted_log_count,
- deleted_log_size,
- deleted_smallest_log,
- deleted_largest_log,
- stop_gc_log_index,
- (int)prevent_gc_replicas.size(),
- stop_gc_replica.get_app_id(),
- stop_gc_replica.get_partition_index(),
- stop_gc_decree_gap,
- stop_gc_garbage_max_decree,
- stop_gc_log_max_decree);
+ LOG_INFO_F("gc_shared: deleted some files, file_count_limit = {}, "
+ "reserved_log_count = {}, reserved_log_size = {}, "
+ "reserved_smallest_log = {}, reserved_largest_log = {}, "
+ "to_delete_log_count = {}, to_delete_log_size = {}, "
+ "deleted_log_count = {}, deleted_log_size = {}, "
+ "deleted_smallest_log = {}, deleted_largest_log = {}, "
+ "stop_gc_log_index = {}, stop_gc_replica_count = {}, "
+ "stop_gc_replica = {}.{}, stop_gc_decree_gap = {}, "
+ "stop_gc_garbage_max_decree = {}, stop_gc_log_max_decree = {}",
+ file_count_limit,
+ reserved_log_count,
+ reserved_log_size,
+ reserved_smallest_log,
+ reserved_largest_log,
+ to_delete_log_count,
+ to_delete_log_size,
+ deleted_log_count,
+ deleted_log_size,
+ deleted_smallest_log,
+ deleted_largest_log,
+ stop_gc_log_index,
+ prevent_gc_replicas.size(),
+ stop_gc_replica.get_app_id(),
+ stop_gc_replica.get_partition_index(),
Review Comment:
```suggestion
stop_gc_replica,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org