You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/11/08 18:03:05 UTC

[GitHub] [echarts] zltn opened a new issue #16027: Missing borderRadius when using custom chart with sector shape or no documentation on creating sector shape

zltn opened a new issue #16027:
URL: https://github.com/apache/echarts/issues/16027


   ### Version
   5.2.2
   
   ### Reproduction link
   [https://jsfiddle.net/0bue95q2/](https://jsfiddle.net/0bue95q2/)
   
   ### Steps to reproduce
   - Create a minimal custom chart with a polar coordinate system using the sector shape.  
   - Set a borderRadius on the series itemStyle
   - No border radius like you get with a regular pie chart
   
   What does work is:
   - Create a minimal custom chart with a polar coordinate system using the sector shape.  
   - Set a `cornerRadius` and `innerCornerRadius` when returning the shape in your `renderItem`
   
   ### What is expected?
   I expected to be able to use `borderRadius` with `itemStyle` like on a regular pie chart  when creating a custom chart with a sector segment.
   
   ### What is actually happening?
   You can use `cornerRadius` and `innerCornerRadius` when initiating the shape. This is not documenten but does work. 
   
   ---
   I see two options:
   
   1) actually add a [helper function](https://github.com/apache/echarts/blob/4569dc1d8b712dafb80b16e31c4fed0118e3acbd/src/chart/helper/pieHelper.ts#L25) for the sector shape it can use borderRadius as both the method and terminology will be in line with the pie chart 
   
   2) add `cornerRadius` and `innerCornerRadius` to the sector shape documentation
   
   <!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
   <!-- This issue is in English. DO NOT REMOVE -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang commented on issue #16027: Missing borderRadius when using custom chart with sector shape or no documentation on creating sector shape

Posted by GitBox <gi...@apache.org>.
pissang commented on issue #16027:
URL: https://github.com/apache/echarts/issues/16027#issuecomment-963750942


   Hi
   
   cornerRadius and innerCornerRadius is what actually used in pie sectors. These two are missed in our docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #16027: Missing borderRadius when using custom chart with sector shape or no documentation on creating sector shape

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #16027:
URL: https://github.com/apache/echarts/issues/16027#issuecomment-963421169


   Hi! We've received your issue and please be patient to get responded. 🎉
   The average response time is expected to be within one day for weekdays.
   
   In the meanwhile, please make sure that it contains **a minimum reproducible demo** and necessary **images** to illustrate. Otherwise, our committers will ask you to do so.
   
   *A minimum reproducible demo* should contain as little data and components as possible but can still illustrate your problem. This is the best way for us to reproduce it and solve the problem faster.
   
   You may also check out the [API](https://echarts.apache.org/api.html) and [chart option](https://echarts.apache.org/option.html) to get the answer.
   
   If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical question.
   
   If you are interested in the project, you may also subscribe to our [mailing list](https://echarts.apache.org/maillist.html).
   
   Have a nice day! 🍵


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] pissang edited a comment on issue #16027: Missing borderRadius when using custom chart with sector shape or no documentation on creating sector shape

Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #16027:
URL: https://github.com/apache/echarts/issues/16027#issuecomment-963750942


   cornerRadius and innerCornerRadius is what actually used in pie sectors. These two are missed in our docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org